nagachika	2018-03-07 23:05:38 +0900 (Wed, 07 Mar 2018)

  New Revision: 62690

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=62690

  Log:
    merge revision(s) 60055: [Backport #13856]
    
    io.c: fix segfault with closing socket on Windows
    
    * io.c (fptr_finalize_flush): add an argument to keep GVL.
    * io.c (fptr_finalize): adjust for above change.
    * io.c (io_close_fptr): closing without GVL causes another
      exception while raising exception in another thread. This causes
      segfault on Windows. Keep GVL while closing when another thread
      raises.
      [Bug #13856] [ruby-core:82602]

  Modified directories:
    branches/ruby_2_4/
  Modified files:
    branches/ruby_2_4/io.c
    branches/ruby_2_4/version.h
Index: ruby_2_4/io.c
===================================================================
--- ruby_2_4/io.c	(revision 62689)
+++ ruby_2_4/io.c	(revision 62690)
@@ -4277,7 +4277,7 @@ static void free_io_buffer(rb_io_buffer_ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/io.c#L4277
 static void clear_codeconv(rb_io_t *fptr);
 
 static void
-fptr_finalize_flush(rb_io_t *fptr, int noraise)
+fptr_finalize_flush(rb_io_t *fptr, int noraise, int keepgvl)
 {
     VALUE err = Qnil;
     int fd = fptr->fd;
@@ -4325,7 +4325,7 @@ fptr_finalize_flush(rb_io_t *fptr, int n https://github.com/ruby/ruby/blob/trunk/ruby_2_4/io.c#L4325
          * We assumes it is closed.  */
 
 	/**/
-	int keepgvl = !(mode & FMODE_WRITABLE);
+	keepgvl |= !(mode & FMODE_WRITABLE);
 	keepgvl |= noraise;
 	if ((maygvl_close(fd, keepgvl) < 0) && NIL_P(err))
 	    err = noraise ? Qtrue : INT2NUM(errno);
@@ -4342,7 +4342,7 @@ fptr_finalize_flush(rb_io_t *fptr, int n https://github.com/ruby/ruby/blob/trunk/ruby_2_4/io.c#L4342
 static void
 fptr_finalize(rb_io_t *fptr, int noraise)
 {
-    fptr_finalize_flush(fptr, noraise);
+    fptr_finalize_flush(fptr, noraise, FALSE);
     free_io_buffer(&fptr->rbuf);
     free_io_buffer(&fptr->wbuf);
     clear_codeconv(fptr);
@@ -4422,6 +4422,13 @@ rb_io_memsize(const rb_io_t *fptr) https://github.com/ruby/ruby/blob/trunk/ruby_2_4/io.c#L4422
     return size;
 }
 
+#ifdef _WIN32
+/* keep GVL while closing to prevent crash on Windows */
+# define KEEPGVL TRUE
+#else
+# define KEEPGVL FALSE
+#endif
+
 int rb_notify_fd_close(int fd);
 static rb_io_t *
 io_close_fptr(VALUE io)
@@ -4446,8 +4453,8 @@ io_close_fptr(VALUE io) https://github.com/ruby/ruby/blob/trunk/ruby_2_4/io.c#L4453
 
     fd = fptr->fd;
     busy = rb_notify_fd_close(fd);
-    fptr_finalize_flush(fptr, FALSE);
     if (busy) {
+	fptr_finalize_flush(fptr, FALSE, KEEPGVL);
 	do rb_thread_schedule(); while (rb_notify_fd_close(fd));
     }
     rb_io_fptr_cleanup(fptr, FALSE);
Index: ruby_2_4/version.h
===================================================================
--- ruby_2_4/version.h	(revision 62689)
+++ ruby_2_4/version.h	(revision 62690)
@@ -1,10 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/version.h#L1
 #define RUBY_VERSION "2.4.4"
-#define RUBY_RELEASE_DATE "2018-03-06"
-#define RUBY_PATCHLEVEL 252
+#define RUBY_RELEASE_DATE "2018-03-07"
+#define RUBY_PATCHLEVEL 253
 
 #define RUBY_RELEASE_YEAR 2018
 #define RUBY_RELEASE_MONTH 3
-#define RUBY_RELEASE_DAY 6
+#define RUBY_RELEASE_DAY 7
 
 #include "ruby/version.h"
 
Index: ruby_2_4
===================================================================
--- ruby_2_4	(revision 62689)
+++ ruby_2_4	(revision 62690)

Property changes on: ruby_2_4
___________________________________________________________________
Modified: svn:mergeinfo
## -0,0 +0,1 ##
   Merged /trunk:r60055

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/