nagachika	2018-03-04 07:09:20 +0900 (Sun, 04 Mar 2018)

  New Revision: 62647

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=62647

  Log:
    merge revision(s) 59602,59887: [Backport #13816]
    
    High Sierra's APFS cannot use invalid filenames [Bug #13816]
    
    added workaround for APFS file format.
    
      * TestFileExhaustive#test_atime: It fails with nano-sec precise.
        I changed to use unixtime for this assertion for APFS.
      * TestFileExhaustive#test_expand_path: skip assertion when given
        invalid charactor on APFS.
    
      [Bug #13816][ruby-core:82383]

  Modified directories:
    branches/ruby_2_4/
  Modified files:
    branches/ruby_2_4/test/ruby/test_dir_m17n.rb
    branches/ruby_2_4/test/ruby/test_file_exhaustive.rb
    branches/ruby_2_4/version.h
Index: ruby_2_4/version.h
===================================================================
--- ruby_2_4/version.h	(revision 62646)
+++ ruby_2_4/version.h	(revision 62647)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/version.h#L1
 #define RUBY_VERSION "2.4.4"
 #define RUBY_RELEASE_DATE "2018-03-04"
-#define RUBY_PATCHLEVEL 247
+#define RUBY_PATCHLEVEL 248
 
 #define RUBY_RELEASE_YEAR 2018
 #define RUBY_RELEASE_MONTH 3
Index: ruby_2_4/test/ruby/test_dir_m17n.rb
===================================================================
--- ruby_2_4/test/ruby/test_dir_m17n.rb	(revision 62646)
+++ ruby_2_4/test/ruby/test_dir_m17n.rb	(revision 62647)
@@ -1,6 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_dir_m17n.rb#L1
 # frozen_string_literal: false
 require 'test/unit'
 require 'tmpdir'
+require '-test-/file'
 
 class TestDir_M17N < Test::Unit::TestCase
   def with_tmpdir
@@ -59,6 +60,8 @@ class TestDir_M17N < Test::Unit::TestCas https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_dir_m17n.rb#L60
 
   def test_filename_extutf8_invalid
     return if /cygwin/ =~ RUBY_PLATFORM
+    # High Sierra's APFS cannot use invalid filenames
+    return if Bug::File::Fs.fsname(Dir.tmpdir) == "apfs"
     with_tmpdir {|d|
       assert_separately(%w[-EASCII-8BIT], <<-'EOS', :chdir=>d)
         filename = "\xff".force_encoding("ASCII-8BIT") # invalid byte sequence as UTF-8
@@ -375,7 +378,12 @@ class TestDir_M17N < Test::Unit::TestCas https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_dir_m17n.rb#L378
       a = "file_one*".force_encoding Encoding::IBM437
       b = "file_two*".force_encoding Encoding::EUC_JP
       assert_equal([a, b].map(&:encoding), Dir[a, b].map(&:encoding))
-      dir = "\u{76EE 5F551}"
+      if Bug::File::Fs.fsname(Dir.pwd) == "apfs"
+        # High Sierra's APFS cannot use filenames with undefined character
+        dir = "\u{76EE}"
+      else
+        dir = "\u{76EE 5F551}"
+      end
       Dir.mkdir(dir)
       list << dir
       bug12081 = '[ruby-core:73868] [Bug #12081]'
Index: ruby_2_4/test/ruby/test_file_exhaustive.rb
===================================================================
--- ruby_2_4/test/ruby/test_file_exhaustive.rb	(revision 62646)
+++ ruby_2_4/test/ruby/test_file_exhaustive.rb	(revision 62647)
@@ -3,6 +3,7 @@ require "test/unit" https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_file_exhaustive.rb#L3
 require "fileutils"
 require "tmpdir"
 require "socket"
+require '-test-/file'
 
 class TestFileExhaustive < Test::Unit::TestCase
   DRIVE = Dir.pwd[%r'\A(?:[a-z]:|//[^/]+/[^/]+)'i]
@@ -572,7 +573,13 @@ class TestFileExhaustive < Test::Unit::T https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_file_exhaustive.rb#L573
       t2 = File.open(file) {|f| f.atime}
       assert_kind_of(Time, t1)
       assert_kind_of(Time, t2)
-      assert_equal(t1, t2)
+      # High Sierra's APFS can handle nano-sec precise.
+      # t1 value is difference from t2 on APFS.
+      if Bug::File::Fs.fsname(Dir.tmpdir) == "apfs"
+        assert_equal(t1.to_i, t2.to_i)
+      else
+        assert_equal(t1, t2)
+      end
     end
     assert_raise(Errno::ENOENT) { File.atime(nofile) }
   end
@@ -749,6 +756,8 @@ class TestFileExhaustive < Test::Unit::T https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_file_exhaustive.rb#L756
         begin
           open(file) {}
         rescue
+          # High Sierra's APFS cannot use filenames with undefined character
+          next if Bug::File::Fs.fsname(Dir.tmpdir) == "apfs"
           assert_equal(file, full_path, mesg)
         else
           assert_equal(regular_file, full_path, mesg)
Index: ruby_2_4
===================================================================
--- ruby_2_4	(revision 62646)
+++ ruby_2_4	(revision 62647)

Property changes on: ruby_2_4
___________________________________________________________________
Modified: svn:mergeinfo
## -0,0 +0,1 ##
   Merged /trunk:r59602,59887

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/