[前][次][番号順一覧][スレッド一覧]

ruby-changes:48314

From: usa <ko1@a...>
Date: Wed, 25 Oct 2017 22:29:33 +0900 (JST)
Subject: [ruby-changes:48314] usa:r60428 (trunk): Get rid of a test error on Windows caused by r60417

usa	2017-10-25 22:29:27 +0900 (Wed, 25 Oct 2017)

  New Revision: 60428

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=60428

  Log:
    Get rid of a test error on Windows caused by r60417
    
    * test/testunit/test_parallel.rb (teardown): this code seems to allow
      `Errno::EPIPE` from @worker_in.  in such case, `close` may also raise the same
      exception.
      I'm not confident in this conclusion and still doubt that we should revert
      r60417 instead of this commit or not.

  Modified files:
    trunk/test/testunit/test_parallel.rb
Index: test/testunit/test_parallel.rb
===================================================================
--- test/testunit/test_parallel.rb	(revision 60427)
+++ test/testunit/test_parallel.rb	(revision 60428)
@@ -34,8 +34,12 @@ module TestParallel https://github.com/ruby/ruby/blob/trunk/test/testunit/test_parallel.rb#L34
         end
       end
     ensure
-      @worker_in.close
-      @worker_out.close
+      begin
+        @worker_in.close
+        @worker_out.close
+      rescue Errno::EPIPE
+        # may already broken and rescue'ed in above code
+      end
     end
 
     def test_run

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]