[前][次][番号順一覧][スレッド一覧]

ruby-changes:47822

From: mame <ko1@a...>
Date: Sun, 17 Sep 2017 13:30:35 +0900 (JST)
Subject: [ruby-changes:47822] mame:r59940 (trunk): run-lcov.rb: wrongly used unique ID as lineno

mame	2017-09-17 13:30:30 +0900 (Sun, 17 Sep 2017)

  New Revision: 59940

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59940

  Log:
    run-lcov.rb: wrongly used unique ID as lineno
    
    The second value of key of branch/method coverage is unique ID, not
    lineno.

  Modified files:
    trunk/tool/run-lcov.rb
Index: tool/run-lcov.rb
===================================================================
--- tool/run-lcov.rb	(revision 59939)
+++ tool/run-lcov.rb	(revision 59940)
@@ -63,7 +63,7 @@ def gen_rb_lcov(file) https://github.com/ruby/ruby/blob/trunk/tool/run-lcov.rb#L63
 
       # function coverage
       total = covered = 0
-      cov[:methods].each do |(name, lineno), count|
+      cov[:methods].each do |(name, _, lineno), count|
         f.puts "FN:#{ lineno },#{ name }"
         total += 1
         covered += 1 if count > 0
@@ -88,7 +88,7 @@ def gen_rb_lcov(file) https://github.com/ruby/ruby/blob/trunk/tool/run-lcov.rb#L88
       # branch coverage
       total = covered = 0
       id = 0
-      cov[:branches].each do |(base_type, base_lineno), targets|
+      cov[:branches].each do |(base_type, _, base_lineno), targets|
         i = 0
         targets.each do |(target_type, target_lineno), count|
           f.puts "BRDA:#{ base_lineno },#{ id },#{ i },#{ count }"

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]