[前][次][番号順一覧][スレッド一覧]

ruby-changes:46523

From: normal <ko1@a...>
Date: Wed, 10 May 2017 04:52:15 +0900 (JST)
Subject: [ruby-changes:46523] normal:r58644 (trunk): test/thread: relax internal implementation check in error message

normal	2017-05-10 04:52:10 +0900 (Wed, 10 May 2017)

  New Revision: 58644

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58644

  Log:
    test/thread: relax internal implementation check in error message
    
    Queue, SizedQueue, and ConditionVariable internal implementation
    should not be tied to using arrays.  Implementation details can
    change and I am working on a change to remove the dependency on
    arrays (as others may attempt, too) by using ccan/list for the
    waiter list.
    
    * test/thread/test_cv.rb (test_dump): remove check for Array
    * test/thread/test_queue.rb (test_dump): ditto
      [ruby-core:81001] [Misc #13541]

  Modified files:
    trunk/test/thread/test_cv.rb
    trunk/test/thread/test_queue.rb
Index: test/thread/test_cv.rb
===================================================================
--- test/thread/test_cv.rb	(revision 58643)
+++ test/thread/test_cv.rb	(revision 58644)
@@ -218,7 +218,7 @@ INPUT https://github.com/ruby/ruby/blob/trunk/test/thread/test_cv.rb#L218
     end
 
     condvar = DumpableCV.new
-    assert_raise_with_message(TypeError, /internal Array/, bug9674) do
+    assert_raise(TypeError, bug9674) do
       Marshal.dump(condvar)
     end
   end
Index: test/thread/test_queue.rb
===================================================================
--- test/thread/test_queue.rb	(revision 58643)
+++ test/thread/test_queue.rb	(revision 58644)
@@ -278,7 +278,7 @@ class TestQueue < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/thread/test_queue.rb#L278
     end
 
     q = DumpableQueue.new
-    assert_raise_with_message(TypeError, /internal Array/, bug9674) do
+    assert_raise(TypeError, bug9674) do
       Marshal.dump(q)
     end
   end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]