ruby-changes:46450
From: normal <ko1@a...>
Date: Thu, 4 May 2017 17:56:00 +0900 (JST)
Subject: [ruby-changes:46450] normal:r58565 (trunk): benchmark/bm_vm1_gc_wb_*.rb: fix GC.start args for invalid keyword
normal 2017-05-04 17:55:54 +0900 (Thu, 04 May 2017) New Revision: 58565 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58565 Log: benchmark/bm_vm1_gc_wb_*.rb: fix GC.start args for invalid keyword "lazy_sweep" does not appear to have ever been a valid kwarg for GC.start, however the opposite of "lazy_sweep" appears to be "immediate_sweep". So use immediate_sweep, and flip the boolean value of each arg. I guess this only started failing with r56981 in Dec 2016 ("class.c: missing unknown_keyword_error", commit e3f0cca2f26ba44c810ac980cdff7dda129ae533) * benchmark/bm_vm1_gc_wb_ary.rb: "lazy_sweep: false" => "immediate_sweep: true" * benchmark/bm_vm1_gc_wb_ary_promoted.rb: ditto * benchmark/bm_vm1_gc_wb_obj.rb: ditto * benchmark/bm_vm1_gc_wb_obj_promoted.rb: ditto Modified files: trunk/benchmark/bm_vm1_gc_wb_ary.rb trunk/benchmark/bm_vm1_gc_wb_ary_promoted.rb trunk/benchmark/bm_vm1_gc_wb_obj.rb trunk/benchmark/bm_vm1_gc_wb_obj_promoted.rb Index: benchmark/bm_vm1_gc_wb_obj_promoted.rb =================================================================== --- benchmark/bm_vm1_gc_wb_obj_promoted.rb (revision 58564) +++ benchmark/bm_vm1_gc_wb_obj_promoted.rb (revision 58565) @@ -4,7 +4,7 @@ end https://github.com/ruby/ruby/blob/trunk/benchmark/bm_vm1_gc_wb_obj_promoted.rb#L4 long_lived = C.new if RUBY_VERSION >= "2.2.0" - 3.times{ GC.start(full_mark: false, immediate_mark: true, lazy_sweep: false) } + 3.times{ GC.start(full_mark: false, immediate_mark: true, immediate_sweep: true) } elsif GC.start end Index: benchmark/bm_vm1_gc_wb_ary_promoted.rb =================================================================== --- benchmark/bm_vm1_gc_wb_ary_promoted.rb (revision 58564) +++ benchmark/bm_vm1_gc_wb_ary_promoted.rb (revision 58565) @@ -1,7 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/benchmark/bm_vm1_gc_wb_ary_promoted.rb#L1 long_lived = [] if RUBY_VERSION > "2.2.0" - 3.times{ GC.start(full_mark: false, immediate_mark: true, lazy_sweep: false) } + 3.times{ GC.start(full_mark: false, immediate_mark: true, immediate_sweep: true) } elsif GC.start end Index: benchmark/bm_vm1_gc_wb_ary.rb =================================================================== --- benchmark/bm_vm1_gc_wb_ary.rb (revision 58564) +++ benchmark/bm_vm1_gc_wb_ary.rb (revision 58565) @@ -1,7 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/benchmark/bm_vm1_gc_wb_ary.rb#L1 short_lived_ary = [] if RUBY_VERSION >= "2.2.0" - GC.start(full_mark: false, immediate_mark: true, lazy_sweep: false) + GC.start(full_mark: false, immediate_mark: true, immediate_sweep: true) end i = 0 Index: benchmark/bm_vm1_gc_wb_obj.rb =================================================================== --- benchmark/bm_vm1_gc_wb_obj.rb (revision 58564) +++ benchmark/bm_vm1_gc_wb_obj.rb (revision 58565) @@ -4,7 +4,7 @@ end https://github.com/ruby/ruby/blob/trunk/benchmark/bm_vm1_gc_wb_obj.rb#L4 short_lived_obj = C.new if RUBY_VERSION >= "2.2.0" - GC.start(full_mark: false, immediate_mark: true, lazy_sweep: false) + GC.start(full_mark: false, immediate_mark: true, immediate_sweep: true) end i = 0 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/