[前][次][番号順一覧][スレッド一覧]

ruby-changes:46105

From: nagachika <ko1@a...>
Date: Tue, 28 Mar 2017 01:41:04 +0900 (JST)
Subject: [ruby-changes:46105] nagachika:r58176 (ruby_2_3): merge revision(s) 57374: [Backport #13135]

nagachika	2017-03-28 01:41:00 +0900 (Tue, 28 Mar 2017)

  New Revision: 58176

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58176

  Log:
    merge revision(s) 57374: [Backport #13135]
    
    string.c: rindex(//) should set $~.
    
    This seems a bug introduced by r520 (1.4.0).  [ruby-core:79110] [Bug #13135]

  Modified directories:
    branches/ruby_2_3/
  Modified files:
    branches/ruby_2_3/string.c
    branches/ruby_2_3/test/ruby/test_string.rb
    branches/ruby_2_3/version.h
Index: ruby_2_3/test/ruby/test_string.rb
===================================================================
--- ruby_2_3/test/ruby/test_string.rb	(revision 58175)
+++ ruby_2_3/test/ruby/test_string.rb	(revision 58176)
@@ -1110,6 +1110,9 @@ class TestString < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/ruby_2_3/test/ruby/test_string.rb#L1110
 
     assert_nil("foo".rindex(//, -100))
     assert_nil($~)
+
+    assert_equal(3, "foo".rindex(//))
+    assert_equal([3, 3], $~.offset(0))
   end
 
   def test_rjust
Index: ruby_2_3/version.h
===================================================================
--- ruby_2_3/version.h	(revision 58175)
+++ ruby_2_3/version.h	(revision 58176)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/version.h#L1
 #define RUBY_VERSION "2.3.3"
 #define RUBY_RELEASE_DATE "2017-03-28"
-#define RUBY_PATCHLEVEL 285
+#define RUBY_PATCHLEVEL 286
 
 #define RUBY_RELEASE_YEAR 2017
 #define RUBY_RELEASE_MONTH 3
Index: ruby_2_3/string.c
===================================================================
--- ruby_2_3/string.c	(revision 58175)
+++ ruby_2_3/string.c	(revision 58176)
@@ -3298,10 +3298,8 @@ rb_str_rindex_m(int argc, VALUE *argv, V https://github.com/ruby/ruby/blob/trunk/ruby_2_3/string.c#L3298
 	pos = str_offset(RSTRING_PTR(str), RSTRING_END(str), pos,
 			 enc, single_byte_optimizable(str));
 
-	if (!RREGEXP(sub)->ptr || RREGEXP_SRC_LEN(sub)) {
-	    pos = rb_reg_search(sub, str, pos, 1);
-	    pos = rb_str_sublen(str, pos);
-	}
+	pos = rb_reg_search(sub, str, pos, 1);
+	pos = rb_str_sublen(str, pos);
 	if (pos >= 0) return LONG2NUM(pos);
 	break;
 

Property changes on: ruby_2_3
___________________________________________________________________
Modified: svn:mergeinfo
   Merged /trunk:r57374


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]