nagachika	2017-03-28 01:17:42 +0900 (Tue, 28 Mar 2017)

  New Revision: 58173

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58173

  Log:
    merge revision(s) 57236: [Backport #13089]
    
    rational.c: memory leak in gcd
    
    * rational.c (rb_gcd_gmp): fix memory leak.  patched by KISHIMOTO,
      Makoto <ksmakoto AT dd.iij4u.or.jp> in [ruby-dev:49934].
      [Bug #13089]

  Modified directories:
    branches/ruby_2_3/
  Modified files:
    branches/ruby_2_3/rational.c
    branches/ruby_2_3/test/ruby/test_rational.rb
    branches/ruby_2_3/version.h
Index: ruby_2_3/version.h
===================================================================
--- ruby_2_3/version.h	(revision 58172)
+++ ruby_2_3/version.h	(revision 58173)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/version.h#L1
 #define RUBY_VERSION "2.3.3"
 #define RUBY_RELEASE_DATE "2017-03-28"
-#define RUBY_PATCHLEVEL 282
+#define RUBY_PATCHLEVEL 283
 
 #define RUBY_RELEASE_YEAR 2017
 #define RUBY_RELEASE_MONTH 3
Index: ruby_2_3/test/ruby/test_rational.rb
===================================================================
--- ruby_2_3/test/ruby/test_rational.rb	(revision 58172)
+++ ruby_2_3/test/ruby/test_rational.rb	(revision 58173)
@@ -870,6 +870,16 @@ class Rational_Test < Test::Unit::TestCa https://github.com/ruby/ruby/blob/trunk/ruby_2_3/test/ruby/test_rational.rb#L870
     assert_equal(1152921470247108503, 1073741789.lcm(1073741827))
   end
 
+  def test_gcd_no_memory_leak
+    assert_no_memory_leak([], "#{<<-"begin;"}", "#{<<-"end;"}", limit: 1.2, rss: true)
+    x = (1<<121) + 1
+    y = (1<<99) + 1
+    1000.times{x.gcd(y)}
+    begin;
+      100.times {1000.times{x.gcd(y)}}
+    end;
+  end
+
   def test_supp
     assert_equal(true, 1.real?)
     assert_equal(true, 1.1.real?)
Index: ruby_2_3/rational.c
===================================================================
--- ruby_2_3/rational.c	(revision 58172)
+++ ruby_2_3/rational.c	(revision 58173)
@@ -286,10 +286,15 @@ rb_gcd_gmp(VALUE x, VALUE y) https://github.com/ruby/ruby/blob/trunk/ruby_2_3/rational.c#L286
 
     mpz_gcd(mz, mx, my);
 
+    mpz_clear(mx);
+    mpz_clear(my);
+
     zn = (mpz_sizeinbase(mz, 16) + SIZEOF_BDIGIT*2 - 1) / (SIZEOF_BDIGIT*2);
     z = rb_big_new(zn, 1);
     mpz_export(BIGNUM_DIGITS(z), &count, -1, sizeof(BDIGIT), 0, nails, mz);
 
+    mpz_clear(mz);
+
     return rb_big_norm(z);
 }
 #endif

Property changes on: ruby_2_3
___________________________________________________________________
Modified: svn:mergeinfo
   Merged /trunk:r57236


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/