ruby-changes:45956
From: nagachika <ko1@a...>
Date: Mon, 20 Mar 2017 06:22:51 +0900 (JST)
Subject: [ruby-changes:45956] nagachika:r58027 (ruby_2_3): merge revision(s) 57595: [Backport #8996]
nagachika 2017-03-20 06:22:46 +0900 (Mon, 20 Mar 2017) New Revision: 58027 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58027 Log: merge revision(s) 57595: [Backport #8996] check thread deadness correctly. Modified directories: branches/ruby_2_3/ Modified files: branches/ruby_2_3/test/ruby/test_thread.rb branches/ruby_2_3/thread.c branches/ruby_2_3/version.h Index: ruby_2_3/test/ruby/test_thread.rb =================================================================== --- ruby_2_3/test/ruby/test_thread.rb (revision 58026) +++ ruby_2_3/test/ruby/test_thread.rb (revision 58027) @@ -1104,4 +1104,14 @@ q.pop https://github.com/ruby/ruby/blob/trunk/ruby_2_3/test/ruby/test_thread.rb#L1104 c = Class.new(Thread) {def initialize() self.name = "foo"; super; end} assert_equal("foo", c.new {Thread.current.name}.value) end + + def test_thread_interrupt_for_killed_thread + assert_normal_exit(<<-_end, '[Bug #8996]', timeout: 5, timeout_error: nil) + trap(:TERM){exit} + while true + t = Thread.new{sleep 0} + t.raise Interrupt + end + _end + end end Index: ruby_2_3/thread.c =================================================================== --- ruby_2_3/thread.c (revision 58026) +++ ruby_2_3/thread.c (revision 58027) @@ -2090,6 +2090,13 @@ rb_threadptr_raise(rb_thread_t *th, int https://github.com/ruby/ruby/blob/trunk/ruby_2_3/thread.c#L2090 else { exc = rb_make_exception(argc, argv); } + + /* making an exception object can switch thread, + so we need to check thread deadness again */ + if (rb_threadptr_dead(th)) { + return Qnil; + } + rb_threadptr_setup_exception(GET_THREAD(), exc, Qundef); rb_threadptr_pending_interrupt_enque(th, exc); rb_threadptr_interrupt(th); Index: ruby_2_3/version.h =================================================================== --- ruby_2_3/version.h (revision 58026) +++ ruby_2_3/version.h (revision 58027) @@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/version.h#L1 #define RUBY_VERSION "2.3.3" #define RUBY_RELEASE_DATE "2017-03-20" -#define RUBY_PATCHLEVEL 248 +#define RUBY_PATCHLEVEL 249 #define RUBY_RELEASE_YEAR 2017 #define RUBY_RELEASE_MONTH 3 Property changes on: ruby_2_3 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r57595 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/