naruse	2017-03-13 03:01:22 +0900 (Mon, 13 Mar 2017)

  New Revision: 57939

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=57939

  Log:
    merge revision(s) 57415,57463,57474:
    
    eval.c: copy special exception
    
    * eval.c (setup_exception): make unfrozen copy of special
      exception before setting up a cause.
    reduce iterations for slower machines
    test_io.rb: separate a test
    
    * test/ruby/test_io.rb (test_closed_stream_in_rescue): run in a
      separated process.

  Modified directories:
    branches/ruby_2_4/
  Modified files:
    branches/ruby_2_4/eval.c
    branches/ruby_2_4/internal.h
    branches/ruby_2_4/test/ruby/test_io.rb
    branches/ruby_2_4/version.h
    branches/ruby_2_4/vm_insnhelper.c
Index: ruby_2_4/eval.c
===================================================================
--- ruby_2_4/eval.c	(revision 57938)
+++ ruby_2_4/eval.c	(revision 57939)
@@ -470,6 +470,17 @@ sysstack_error_p(VALUE exc) https://github.com/ruby/ruby/blob/trunk/ruby_2_4/eval.c#L470
     return exc == sysstack_error || (!SPECIAL_CONST_P(exc) && RBASIC_CLASS(exc) == rb_eSysStackError);
 }
 
+static inline int
+special_exception_p(rb_thread_t *th, VALUE exc)
+{
+    enum ruby_special_exceptions i;
+    const VALUE *exceptions = th->vm->special_exceptions;
+    for (i = 0; i < ruby_special_error_count; ++i) {
+	if (exceptions[i] == exc) return TRUE;
+    }
+    return FALSE;
+}
+
 static void
 setup_exception(rb_thread_t *th, int tag, volatile VALUE mesg, VALUE cause)
 {
@@ -487,6 +498,9 @@ setup_exception(rb_thread_t *th, int tag https://github.com/ruby/ruby/blob/trunk/ruby_2_4/eval.c#L498
 	mesg = rb_exc_new(rb_eRuntimeError, 0, 0);
 	nocause = 0;
     }
+    else if (special_exception_p(th, mesg)) {
+	mesg = ruby_vm_special_exception_copy(mesg);
+    }
     if (cause != Qundef) {
 	exc_setup_cause(mesg, cause);
     }
@@ -503,9 +517,6 @@ setup_exception(rb_thread_t *th, int tag https://github.com/ruby/ruby/blob/trunk/ruby_2_4/eval.c#L517
 	if (sysstack_error_p(mesg)) {
 	    if (NIL_P(rb_attr_get(mesg, idBt))) {
 		at = rb_vm_backtrace_object();
-		if (mesg == sysstack_error) {
-		    mesg = ruby_vm_sysstack_error_copy();
-		}
 		rb_ivar_set(mesg, idBt, at);
 		rb_ivar_set(mesg, idBt_locations, at);
 	    }
Index: ruby_2_4/version.h
===================================================================
--- ruby_2_4/version.h	(revision 57938)
+++ ruby_2_4/version.h	(revision 57939)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/version.h#L1
 #define RUBY_VERSION "2.4.0"
 #define RUBY_RELEASE_DATE "2017-03-13"
-#define RUBY_PATCHLEVEL 93
+#define RUBY_PATCHLEVEL 94
 
 #define RUBY_RELEASE_YEAR 2017
 #define RUBY_RELEASE_MONTH 3
Index: ruby_2_4/test/ruby/test_io.rb
===================================================================
--- ruby_2_4/test/ruby/test_io.rb	(revision 57938)
+++ ruby_2_4/test/ruby/test_io.rb	(revision 57939)
@@ -3370,7 +3370,7 @@ __END__ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_io.rb#L3370
     assert_separately([], "#{<<-"begin;"}\n#{<<-"end;"}")
     bug13076 = '[ruby-core:78845] [Bug #13076]'
     begin;
-      100.times do |i|
+      10.times do |i|
         a = []
         t = []
         10.times do
@@ -3483,5 +3483,30 @@ __END__ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_io.rb#L3483
         assert_equal(["foo\n", "bar\n", "baz\n"], IO.readlines(t.path))
       }
     end
+
+    def test_closed_stream_in_rescue
+      assert_separately([], "#{<<-"begin;"}\n#{<<~"end;"}")
+      begin;
+      10.times do
+        assert_nothing_raised(RuntimeError, /frozen IOError/) do
+          IO.pipe do |r, w|
+            begin
+              th = Thread.start {r.close}
+              r.gets
+            rescue IOError
+              # swallow pending exceptions
+              begin
+                sleep 0.001
+              rescue IOError
+                retry
+              end
+            ensure
+              th.kill.join
+            end
+          end
+        end
+      end
+      end;
+    end
   end
 end
Index: ruby_2_4/vm_insnhelper.c
===================================================================
--- ruby_2_4/vm_insnhelper.c	(revision 57938)
+++ ruby_2_4/vm_insnhelper.c	(revision 57939)
@@ -22,17 +22,17 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/vm_insnhelper.c#L22
 static rb_control_frame_t *vm_get_ruby_level_caller_cfp(const rb_thread_t *th, const rb_control_frame_t *cfp);
 
 VALUE
-ruby_vm_sysstack_error_copy(void)
+ruby_vm_special_exception_copy(VALUE exc)
 {
-    VALUE e = rb_obj_alloc(rb_eSysStackError);
-    rb_obj_copy_ivar(e, sysstack_error);
+    VALUE e = rb_obj_alloc(rb_class_real(RBASIC_CLASS(exc)));
+    rb_obj_copy_ivar(e, exc);
     return e;
 }
 
 static void
 vm_stackoverflow(void)
 {
-    rb_exc_raise(ruby_vm_sysstack_error_copy());
+    rb_exc_raise(ruby_vm_special_exception_copy(sysstack_error));
 }
 
 #if VM_CHECK_MODE > 0
Index: ruby_2_4/internal.h
===================================================================
--- ruby_2_4/internal.h	(revision 57938)
+++ ruby_2_4/internal.h	(revision 57939)
@@ -1574,7 +1574,7 @@ void rb_vm_pop_cfunc_frame(void); https://github.com/ruby/ruby/blob/trunk/ruby_2_4/internal.h#L1574
 int rb_vm_add_root_module(ID id, VALUE module);
 void rb_vm_check_redefinition_by_prepend(VALUE klass);
 VALUE rb_yield_refine_block(VALUE refinement, VALUE refinements);
-VALUE ruby_vm_sysstack_error_copy(void);
+VALUE ruby_vm_special_exception_copy(VALUE);
 PUREFUNC(st_table *rb_vm_fstring_table(void));
 
 

Property changes on: ruby_2_4
___________________________________________________________________
Modified: svn:mergeinfo
   Merged /trunk:r57415,57463,57474


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/