[前][次][番号順一覧][スレッド一覧]

ruby-changes:4581

From: ko1@a...
Date: Fri, 18 Apr 2008 19:00:38 +0900 (JST)
Subject: [ruby-changes:4581] knu - Ruby:r16075 (ruby_1_8): * ext/syck/rubyext.c (syck_genericresolver_node_import): should

knu	2008-04-18 19:00:18 +0900 (Fri, 18 Apr 2008)

  New Revision: 16075

  Modified files:
    branches/ruby_1_8/ChangeLog
    branches/ruby_1_8/ext/syck/rubyext.c

  Log:
    * ext/syck/rubyext.c (syck_genericresolver_node_import): should
      not set instance variable "@kind" before initializing it.
      [ruby-dev:32677]
    
    * ext/syck/rubyext.c (syck_resolver_initialize,
      syck_resolver_detect_implicit, syck_emitter_emit): remove unused
      variables.


  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/ChangeLog?r1=16075&r2=16074&diff_format=u
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/ext/syck/rubyext.c?r1=16075&r2=16074&diff_format=u

Index: ruby_1_8/ext/syck/rubyext.c
===================================================================
--- ruby_1_8/ext/syck/rubyext.c	(revision 16074)
+++ ruby_1_8/ext/syck/rubyext.c	(revision 16075)
@@ -917,7 +917,6 @@
 syck_resolver_initialize( self )
     VALUE self;
 {
-    VALUE tags = rb_hash_new();
     rb_ivar_set(self, s_tags, rb_hash_new());
     return self;
 }
@@ -952,7 +951,6 @@
 syck_resolver_detect_implicit( self, val )
     VALUE self, val;
 {
-    char *type_id;
     return rb_str_new2( "" );
 }
 
@@ -1308,7 +1306,6 @@
         break;
 
         case syck_seq_kind:
-            rb_iv_set(obj, "@kind", sym_seq);
             v = rb_ary_new2( syck_seq_count( n ) );
             for ( i = 0; i < syck_seq_count( n ); i++ )
             {
@@ -1319,10 +1316,10 @@
                 style = sym_inline;
             } 
             obj = rb_funcall( cSeq, s_new, 3, t, v, style );
+            rb_iv_set(obj, "@kind", sym_seq);
         break;
 
         case syck_map_kind:
-            rb_iv_set(obj, "@kind", sym_map);
             v = rb_hash_new();
             for ( i = 0; i < syck_map_count( n ); i++ )
             {
@@ -1333,6 +1330,7 @@
                 style = sym_inline;
             } 
             obj = rb_funcall( cMap, s_new, 3, t, v, style );
+            rb_iv_set(obj, "@kind", sym_map);
         break;
     }
 
@@ -2028,7 +2026,6 @@
     VALUE self;
 {
     VALUE oid, proc;
-    char *anchor_name;
     SyckEmitter *emitter;
     struct emitter_xtra *bonus;
     SYMID symple;
Index: ruby_1_8/ChangeLog
===================================================================
--- ruby_1_8/ChangeLog	(revision 16074)
+++ ruby_1_8/ChangeLog	(revision 16075)
@@ -1,3 +1,13 @@
+Fri Apr 18 18:56:57 2008  Akinori MUSHA  <knu@i...>
+
+	* ext/syck/rubyext.c (syck_genericresolver_node_import): should
+	  not set instance variable "@kind" before initializing it.
+	  [ruby-dev:32677]
+
+	* ext/syck/rubyext.c (syck_resolver_initialize,
+	  syck_resolver_detect_implicit, syck_emitter_emit): remove unused
+	  variables.
+
 Fri Apr 18 18:54:57 2008  Akinori MUSHA  <knu@i...>
 
 	* ext/syck/rubyext.c: Node#value defined twice.

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]