ruby-changes:45159
From: nobu <ko1@a...>
Date: Thu, 29 Dec 2016 18:26:49 +0900 (JST)
Subject: [ruby-changes:45159] nobu:r57232 (trunk): rational.c: fix for mathn
nobu 2016-12-29 18:26:45 +0900 (Thu, 29 Dec 2016) New Revision: 57232 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=57232 Log: rational.c: fix for mathn * rational.c (read_num, read_rat_nos): dispatch by the type of numerator, for mathn. [ruby-core:78893] [Bug #13084] Modified files: trunk/rational.c trunk/test/test_mathn.rb Index: rational.c =================================================================== --- rational.c (revision 57231) +++ rational.c (revision 57232) @@ -2358,11 +2358,22 @@ read_num(const char **s, int numsign, in https://github.com/ruby/ruby/blob/trunk/rational.c#L2358 exp = rb_int_uminus(exp); } - if (numsign == '-') - *num = rb_rational_uminus(*num); + if (numsign == '-') { + if (RB_TYPE_P(*num, T_RATIONAL)) { + *num = rb_rational_uminus(*num); + } + else { + *num = rb_int_uminus(*num); + } + } if (!NIL_P(exp)) { VALUE l = f_expt10(exp); - *num = nurat_mul(*num, l); + if (RB_TYPE_P(*num, T_RATIONAL)) { + *num = nurat_mul(*num, l); + } + else { + *num = rb_int_mul(*num, l); + } } return 1; } @@ -2388,8 +2399,14 @@ read_rat_nos(const char **s, int sign, i https://github.com/ruby/ruby/blob/trunk/rational.c#L2399 (*s)++; if (!read_den(s, strict, &den)) return 0; - if (!(FIXNUM_P(den) && FIX2LONG(den) == 1)) - *num = nurat_div(*num, den); + if (!(FIXNUM_P(den) && FIX2LONG(den) == 1)) { + if (RB_TYPE_P(*num, T_RATIONAL)) { + *num = nurat_div(*num, den); + } + else { + *num = rb_int_div(*num, den); + } + } } return 1; } Index: test/test_mathn.rb =================================================================== --- test/test_mathn.rb (revision 57231) +++ test/test_mathn.rb (revision 57232) @@ -180,4 +180,13 @@ class TestMathn < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/test_mathn.rb#L180 assert_equal((-13/5), (-13/5).round(2, half: :down)) EOS end + + def test_rational + assert_separately(%w[-rmathn], "#{<<-"begin;"}\n#{<<-"end;"}", ignore_stderr: true) + begin; + assert_equal(-5, "-5".to_r) + assert_equal(1, "5/5".to_r) + assert_equal(5, "5e0".to_r) + end; + end end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/