ruby-changes:4365
From: ko1@a...
Date: Sun, 30 Mar 2008 00:48:28 +0900 (JST)
Subject: [ruby-changes:4365] matz - Ruby:r15856 (ruby_1_8): * class.c (clone_method): should copy cref as well.
matz 2008-03-30 00:47:54 +0900 (Sun, 30 Mar 2008) New Revision: 15856 Modified files: branches/ruby_1_8/ChangeLog branches/ruby_1_8/class.c Log: * class.c (clone_method): should copy cref as well. [ruby-core:15833] http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/ChangeLog?r1=15856&r2=15855&diff_format=u http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/class.c?r1=15856&r2=15855&diff_format=u Index: ruby_1_8/class.c =================================================================== --- ruby_1_8/class.c (revision 15855) +++ ruby_1_8/class.c (revision 15856) @@ -48,13 +48,26 @@ return rb_class_boot(super); } +struct clone_method_data { + st_table *tbl; + VALUE klass; +}; + static int -clone_method(mid, body, tbl) +clone_method(mid, body, data) ID mid; NODE *body; - st_table *tbl; + struct clone_method_data *data; { - st_insert(tbl, mid, (st_data_t)NEW_METHOD(body->nd_body, body->nd_noex)); + NODE *fbody = body->nd_body; + + if (fbody && nd_type(fbody) == NODE_SCOPE) { + VALUE cref = data->klass ? + (VALUE)NEW_NODE(NODE_CREF,data->klass,0,fbody->nd_rval) : + fbody->nd_rval; + fbody = NEW_NODE(NODE_SCOPE, fbody->nd_tbl, cref, fbody->nd_next); + } + st_insert(data->tbl, mid, (st_data_t)NEW_METHOD(fbody, body->nd_noex)); return ST_CONTINUE; } @@ -65,7 +78,8 @@ { rb_obj_init_copy(clone, orig); if (!FL_TEST(CLASS_OF(clone), FL_SINGLETON)) { - RBASIC(clone)->klass = rb_singleton_class_clone(orig); + RBASIC(clone)->klass = RBASIC(orig)->klass; + RBASIC(clone)->klass = rb_singleton_class_clone(clone); } RCLASS(clone)->super = RCLASS(orig)->super; if (RCLASS(orig)->iv_tbl) { @@ -78,9 +92,12 @@ st_delete(RCLASS(clone)->iv_tbl, (st_data_t*)&id, 0); } if (RCLASS(orig)->m_tbl) { - RCLASS(clone)->m_tbl = st_init_numtable(); - st_foreach(RCLASS(orig)->m_tbl, clone_method, - (st_data_t)RCLASS(clone)->m_tbl); + struct clone_method_data data; + + data.tbl = RCLASS(clone)->m_tbl = st_init_numtable(); + data.klass = (VALUE)clone; + + st_foreach(RCLASS(orig)->m_tbl, clone_method, (st_data_t)&data); } return clone; @@ -126,9 +143,22 @@ if (RCLASS(klass)->iv_tbl) { clone->iv_tbl = st_copy(RCLASS(klass)->iv_tbl); } - clone->m_tbl = st_init_numtable(); - st_foreach(RCLASS(klass)->m_tbl, clone_method, - (st_data_t)clone->m_tbl); + { + struct clone_method_data data; + + data.tbl = clone->m_tbl = st_init_numtable(); + switch (TYPE(obj)) { + case T_CLASS: + case T_MODULE: + data.klass = obj; + break; + default: + data.klass = 0; + break; + } + + st_foreach(RCLASS(klass)->m_tbl, clone_method, (st_data_t)&data); + } rb_singleton_class_attached(RBASIC(clone)->klass, (VALUE)clone); FL_SET(clone, FL_SINGLETON); return (VALUE)clone; Index: ruby_1_8/ChangeLog =================================================================== --- ruby_1_8/ChangeLog (revision 15855) +++ ruby_1_8/ChangeLog (revision 15856) @@ -82,6 +82,11 @@ * ext/tk/sample/tksleep_sample.rb: sample script about Tk.sleep. +Sat Mar 29 04:08:59 2008 Yukihiro Matsumoto <matz@r...> + + * class.c (clone_method): should copy cref as well. + [ruby-core:15833] + Mon Mar 24 20:07:42 2008 Akinori MUSHA <knu@i...> * eval.c (rb_eval): Call trace hook for if expression after the -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/