ruby-changes:4291
From: ko1@a...
Date: Fri, 14 Mar 2008 17:09:09 +0900 (JST)
Subject: [ruby-changes:4291] matz - Ruby:r15781 (trunk): * lib/cgi.rb (CGI::Cookie::initialize): performance patch from
matz 2008-03-14 17:08:51 +0900 (Fri, 14 Mar 2008) New Revision: 15781 Modified files: trunk/ChangeLog trunk/lib/cgi.rb Log: * lib/cgi.rb (CGI::Cookie::initialize): performance patch from Makoto Kuwata <kwa@k...> in [ruby-dev:34048]. http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/lib/cgi.rb?r1=15781&r2=15780&diff_format=u http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/ChangeLog?r1=15781&r2=15780&diff_format=u Index: ChangeLog =================================================================== --- ChangeLog (revision 15780) +++ ChangeLog (revision 15781) @@ -8,6 +8,11 @@ * configure.in (RUBY_LIB_PREFIX): fix for prefix. +Fri Mar 14 16:35:11 2008 Yukihiro Matsumoto <matz@r...> + + * lib/cgi.rb (CGI::Cookie::initialize): performance patch from + Makoto Kuwata <kwa@k...> in [ruby-dev:34048]. + Fri Mar 14 15:49:05 2008 Nobuyoshi Nakada <nobu@r...> * configure.in (RUBY_LIB_PREFIX): use libdir. Index: lib/cgi.rb =================================================================== --- lib/cgi.rb (revision 15780) +++ lib/cgi.rb (revision 15781) @@ -802,11 +802,16 @@ # # These keywords correspond to attributes of the cookie object. def initialize(name = "", *value) - options = if name.kind_of?(String) - { "name" => name, "value" => value } - else - name - end + if name.kind_of?(String) + @name = name + @value = value + %r|^(.*/)|.match(ENV["SCRIPT_NAME"]) + @path = ($1 or "") + @secure = false + return super(@value) + end + + options = name unless options.has_key?("name") raise ArgumentError, "`name' required" end @@ -890,7 +895,7 @@ if cookies.has_key?(name) values = cookies[name].value + values end - cookies[name] = Cookie::new({ "name" => name, "value" => values }) + cookies[name] = Cookie::new(name, *values) end cookies -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/