ruby-changes:4288
From: ko1@a...
Date: Fri, 14 Mar 2008 16:45:37 +0900 (JST)
Subject: [ruby-changes:4288] matz - Ruby:r15778 (ruby_1_8): * lib/cgi.rb (CGI::Cookie::initialize): performance patch from
matz 2008-03-14 16:45:26 +0900 (Fri, 14 Mar 2008) New Revision: 15778 Modified files: branches/ruby_1_8/ChangeLog branches/ruby_1_8/lib/cgi.rb Log: * lib/cgi.rb (CGI::Cookie::initialize): performance patch from Makoto Kuwata <kwa@k...> in [ruby-dev:34048]. http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/ChangeLog?r1=15778&r2=15777&diff_format=u http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8/lib/cgi.rb?r1=15778&r2=15777&diff_format=u Index: ruby_1_8/ChangeLog =================================================================== --- ruby_1_8/ChangeLog (revision 15777) +++ ruby_1_8/ChangeLog (revision 15778) @@ -1,3 +1,8 @@ +Fri Mar 14 16:35:11 2008 Yukihiro Matsumoto <matz@r...> + + * lib/cgi.rb (CGI::Cookie::initialize): performance patch from + Makoto Kuwata <kwa@k...> in [ruby-dev:34048]. + Fri Mar 14 15:49:05 2008 Nobuyoshi Nakada <nobu@r...> * configure.in (RUBY_LIB_PREFIX): use libdir. Index: ruby_1_8/lib/cgi.rb =================================================================== --- ruby_1_8/lib/cgi.rb (revision 15777) +++ ruby_1_8/lib/cgi.rb (revision 15778) @@ -792,11 +792,16 @@ # # These keywords correspond to attributes of the cookie object. def initialize(name = "", *value) - options = if name.kind_of?(String) - { "name" => name, "value" => value } - else - name - end + if name.kind_of?(String) + @name = name + @value = value + %r|^(.*/)|.match(ENV["SCRIPT_NAME"]) + @path = ($1 or "") + @secure = false + return super(@value) + end + + options = name unless options.has_key?("name") raise ArgumentError, "`name' required" end @@ -880,7 +885,7 @@ if cookies.has_key?(name) values = cookies[name].value + values end - cookies[name] = Cookie::new({ "name" => name, "value" => values }) + cookies[name] = Cookie::new(name, *values) end cookies -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/