[前][次][番号順一覧][スレッド一覧]

ruby-changes:42754

From: akr <ko1@a...>
Date: Sat, 30 Apr 2016 11:12:17 +0900 (JST)
Subject: [ruby-changes:42754] akr:r54828 (trunk): {Fixnum, Bignum}#& is unified into Integer.

akr	2016-04-30 12:08:53 +0900 (Sat, 30 Apr 2016)

  New Revision: 54828

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=54828

  Log:
    {Fixnum,Bignum}#& is unified into Integer.
    
    * numeric.c (int_and): {Fixnum,Bignum}#& is unified into
      Integer.
    
    * bignum.c (rb_big_and): Don't define Bignum#|.

  Modified files:
    trunk/ChangeLog
    trunk/bignum.c
    trunk/numeric.c
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 54827)
+++ ChangeLog	(revision 54828)
@@ -1,3 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sat Apr 30 12:07:42 2016  Tanaka Akira  <akr@f...>
+
+	* numeric.c (int_and): {Fixnum,Bignum}#& is unified into
+	  Integer.
+
+	* bignum.c (rb_big_and): Don't define Bignum#|.
+
 Sat Apr 30 11:56:15 2016  Nobuyoshi Nakada  <nobu@r...>
 
 	* ext/thread: removed dummy extension library.  thread_sync.c
Index: bignum.c
===================================================================
--- bignum.c	(revision 54827)
+++ bignum.c	(revision 54828)
@@ -6430,13 +6430,6 @@ bigand_int(VALUE x, long xn, BDIGIT hibi https://github.com/ruby/ruby/blob/trunk/bignum.c#L6430
     return bignorm(z);
 }
 
-/*
- * call-seq:
- *     big & numeric   ->  integer
- *
- * Performs bitwise +and+ between _big_ and _numeric_.
- */
-
 VALUE
 rb_big_and(VALUE x, VALUE y)
 {
@@ -6970,7 +6963,6 @@ Init_Bignum(void) https://github.com/ruby/ruby/blob/trunk/bignum.c#L6963
     rb_define_method(rb_cBignum, "remainder", rb_big_remainder, 1);
     rb_define_method(rb_cBignum, "fdiv", rb_big_fdiv, 1);
     rb_define_method(rb_cBignum, "**", rb_big_pow, 1);
-    rb_define_method(rb_cBignum, "&", rb_big_and, 1);
     rb_define_method(rb_cBignum, "~", rb_big_neg, 0);
 
     rb_define_method(rb_cBignum, "==", rb_big_eq, 1);
Index: numeric.c
===================================================================
--- numeric.c	(revision 54827)
+++ numeric.c	(revision 54828)
@@ -3889,9 +3889,9 @@ rb_num_coerce_bit(VALUE x, VALUE y, ID f https://github.com/ruby/ruby/blob/trunk/numeric.c#L3889
 }
 
 /*
- * Document-method: Fixnum#&
+ * Document-method: Integer#&
  * call-seq:
- *   fix & integer  ->  integer_result
+ *   integer & integer  ->  integer_result
  *
  * Bitwise AND.
  */
@@ -3912,6 +3912,18 @@ fix_and(VALUE x, VALUE y) https://github.com/ruby/ruby/blob/trunk/numeric.c#L3912
     return rb_funcall(x, '&', 1, y);
 }
 
+static VALUE
+int_and(VALUE x, VALUE y)
+{
+    if (FIXNUM_P(x)) {
+	return fix_and(x, y);
+    }
+    else if (RB_TYPE_P(x, T_BIGNUM)) {
+	return rb_big_and(x, y);
+    }
+    return Qnil;
+}
+
 /*
  * Document-method: Integer#|
  * call-seq:
@@ -4780,7 +4792,7 @@ Init_Numeric(void) https://github.com/ruby/ruby/blob/trunk/numeric.c#L4792
     rb_define_method(rb_cFixnum, "<=", fix_le, 1);
 
     rb_define_method(rb_cFixnum, "~", fix_rev, 0);
-    rb_define_method(rb_cFixnum, "&", fix_and, 1);
+    rb_define_method(rb_cInteger, "&", int_and, 1);
     rb_define_method(rb_cInteger, "|", int_or,  1);
     rb_define_method(rb_cInteger, "^", int_xor, 1);
     rb_define_method(rb_cInteger, "[]", int_aref, 1);

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]