ruby-changes:41062
From: headius <ko1@a...>
Date: Wed, 16 Dec 2015 07:58:45 +0900 (JST)
Subject: [ruby-changes:41062] headius:r53137 (trunk): Remove this test, since it won't reliably pass.
headius 2015-12-16 07:58:25 +0900 (Wed, 16 Dec 2015) New Revision: 53137 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=53137 Log: Remove this test, since it won't reliably pass. At the point where q.size == 0, we can't know that num_threads threads have actually finished. On e.g. JRuby, they may have called pop but not yet exited the Thread's body. Modified files: trunk/test/thread/test_queue.rb Index: test/thread/test_queue.rb =================================================================== --- test/thread/test_queue.rb (revision 53136) +++ test/thread/test_queue.rb (revision 53137) @@ -307,10 +307,7 @@ class TestQueue < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/thread/test_queue.rb#L307 # wait until queue empty (Thread.pass; sleep 0.01) until q.size == 0 - # now there should be some waiting consumers - assert_equal num_threads - num_items, threads.count{|thr| thr.status} - - # tell them all to go away + # close the queue so remaining threads will wake up q.close # wait for them to go away -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/