nobu	2015-12-13 20:41:14 +0900 (Sun, 13 Dec 2015)

  New Revision: 53094

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=53094

  Log:
    parse.y: lex_state bits
    
    * parse.y (build_lex_state_name, trace_lex_state): lex_state is
      now bit flags and can be set 2 bits or more.

  Modified files:
    trunk/ChangeLog
    trunk/parse.y
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 53093)
+++ ChangeLog	(revision 53094)
@@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sun Dec 13 20:41:16 2015  Nobuyoshi Nakada  <nobu@r...>
+
+	* parse.y (build_lex_state_name, trace_lex_state): lex_state is
+	  now bit flags and can be set 2 bits or more.
+
 Sun Dec 13 20:26:30 2015  Yuki Yugui Sonoda  <yugui@y...>
 
 	* test/ruby/test_syntax.rb: fix typo in test
Index: parse.y
===================================================================
--- parse.y	(revision 53093)
+++ parse.y	(revision 53094)
@@ -93,15 +93,12 @@ enum lex_state_e { https://github.com/ruby/ruby/blob/trunk/parse.y#L93
 #define IS_lex_state(ls)	IS_lex_state_for(lex_state, (ls))
 #define IS_lex_state_all(ls)	IS_lex_state_all_for(lex_state, (ls))
 
+# define SET_LEX_STATE(ls) \
+    (lex_state = trace_lex_state(lex_state, (ls), __LINE__))
 #if PARSER_DEBUG
-# define SET_LEX_STATE(ls) do { \
-       printf("lex_state: %s -> %s at L%d\n", \
-              lex_state_name(lex_state), lex_state_name((ls)), __LINE__); \
-       lex_state = (ls); \
-   } while (0)
-static const char *lex_state_name(enum lex_state_e state);
+static enum lex_state_e trace_lex_state(enum lex_state_e from, enum lex_state_e to, int line);
 #else
-# define SET_LEX_STATE(ls) do { lex_state = (ls); } while (0)
+# define trace_lex_state(from, to, line) (to)
 #endif
 
 typedef VALUE stack_type;
@@ -9183,19 +9180,51 @@ id_is_var_gen(struct parser_params *pars https://github.com/ruby/ruby/blob/trunk/parse.y#L9180
 #endif /* !RIPPER */
 
 #if PARSER_DEBUG
+static const char lex_state_names[][13] = {
+    "EXPR_BEG",    "EXPR_END",    "EXPR_ENDARG", "EXPR_ENDFN",  "EXPR_ARG",
+    "EXPR_CMDARG", "EXPR_MID",    "EXPR_FNAME",  "EXPR_DOT",    "EXPR_CLASS",
+    "EXPR_LABEL",  "EXPR_LABELED",
+};
+
 static const char *
-lex_state_name(enum lex_state_e state)
+build_lex_state_name(enum lex_state_e state, char *buf, size_t size)
 {
-    static const char names[][13] = {
-        "EXPR_NONE",
-	"EXPR_BEG",    "EXPR_END",    "EXPR_ENDARG", "EXPR_ENDFN",  "EXPR_ARG",
-	"EXPR_CMDARG", "EXPR_MID",    "EXPR_FNAME",  "EXPR_DOT",    "EXPR_CLASS",
-	"EXPR_LABEL",  "EXPR_LABELED",
-    };
-
-    if ((unsigned)state & ~(~0u << EXPR_MAX_STATE))
-	return names[ffs(state)];
-    return NULL;
+    int i, sep = 0;
+    char *p = buf;
+    unsigned int mask = 1;
+    size_t n;
+    static const char none[] = "EXPR_NONE";
+
+    for (i = 0; i < EXPR_MAX_STATE; ++i, mask <<= 1) {
+	if ((unsigned)state & mask) {
+	    if (sep) {
+		if (size < 2) break;
+		--size;
+		*p++ = '|';
+	    }
+	    sep = 1;
+	    n = strlcpy(p, lex_state_names[i], size);
+	    if (n >= size) break;
+	    size -= n;
+	    p += n;
+	}
+    }
+    if (p == buf && size >= sizeof(none)) {
+	n = strlcpy(buf, none, size);
+	p += n;
+    }
+    *p = '\0';
+    return buf;
+}
+
+static enum lex_state_e
+trace_lex_state(enum lex_state_e from, enum lex_state_e to, int line)
+{
+    char buf1[sizeof(lex_state_names)], buf2[sizeof(lex_state_names)];
+    build_lex_state_name(from, buf1, sizeof(buf1));
+    build_lex_state_name(to, buf2, sizeof(buf2));
+    printf("lex_state: %s -> %s at L%d\n", buf1, buf2, line);
+    return to;
 }
 #endif
 
@@ -10725,9 +10754,6 @@ rb_init_parse(void) https://github.com/ruby/ruby/blob/trunk/parse.y#L10754
     /* just to suppress unused-function warnings */
     (void)nodetype;
     (void)nodeline;
-#if PARSER_DEBUG
-    (void)lex_state_name(-1);
-#endif
 }
 #endif /* !RIPPER */
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/