[前][次][番号順一覧][スレッド一覧]

ruby-changes:40247

From: ngoto <ko1@a...>
Date: Thu, 29 Oct 2015 00:37:00 +0900 (JST)
Subject: [ruby-changes:40247] ngoto:r52328 (trunk): revert r52312 because the failure does not always occur on Solaris

ngoto	2015-10-29 00:36:49 +0900 (Thu, 29 Oct 2015)

  New Revision: 52328

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=52328

  Log:
    revert r52312 because the failure does not always occur on Solaris
    depending on the content of /etc/inet/services, and skipping the
    assertion by using RUBY_PLATFORM is generally a bad idea.
    In addition, no ChangeLog is given with the commit.

  Modified files:
    trunk/test/rubygems/test_gem_commands_server_command.rb
Index: test/rubygems/test_gem_commands_server_command.rb
===================================================================
--- test/rubygems/test_gem_commands_server_command.rb	(revision 52327)
+++ test/rubygems/test_gem_commands_server_command.rb	(revision 52328)
@@ -37,11 +37,8 @@ class TestGemCommandsServerCommand < Gem https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_server_command.rb#L37
     @cmd.send :handle_options, %w[-p 65535]
     assert_equal 65535, @cmd.options[:port]
 
-    if /solaris/ !~ RUBY_PLATFORM
-      # solaris will raise OptionParser::InvalidArgument
-      @cmd.send :handle_options, %w[-p http]
-      assert_equal 80, @cmd.options[:port]
-    end
+    @cmd.send :handle_options, %w[-p http]
+    assert_equal 80, @cmd.options[:port]
 
     e = assert_raises OptionParser::InvalidArgument do
       @cmd.send :handle_options, %w[-p nonexistent]

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]