ruby-changes:37706
From: nagachika <ko1@a...>
Date: Sun, 1 Mar 2015 03:13:57 +0900 (JST)
Subject: [ruby-changes:37706] nagachika:r49787 (ruby_2_1): merge revision(s) r49221: [Backport #10731]
nagachika 2015-03-01 03:13:42 +0900 (Sun, 01 Mar 2015) New Revision: 49787 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=49787 Log: merge revision(s) r49221: [Backport #10731] * vm_method.c (rb_alias): raise a NameError when creating alias to a refined method if the original method of the refined method is not defined. [ruby-core:67523] [Bug #10731] Modified directories: branches/ruby_2_1/ Modified files: branches/ruby_2_1/ChangeLog branches/ruby_2_1/test/ruby/test_refinement.rb branches/ruby_2_1/version.h branches/ruby_2_1/vm_method.c Index: ruby_2_1/ChangeLog =================================================================== --- ruby_2_1/ChangeLog (revision 49786) +++ ruby_2_1/ChangeLog (revision 49787) @@ -1,3 +1,9 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_1/ChangeLog#L1 +Sun Mar 1 02:30:23 2015 Seiei Higa <hanachin@g...> + + * vm_method.c (rb_alias): raise a NameError when creating alias to + a refined method if the original method of the refined method is + not defined. [ruby-core:67523] [Bug #10731] + Sun Mar 1 01:17:24 2015 Seiei Higa <hanachin@g...> * vm_method.c (rb_export_method): bail out if the original method Index: ruby_2_1/vm_method.c =================================================================== --- ruby_2_1/vm_method.c (revision 49786) +++ ruby_2_1/vm_method.c (revision 49787) @@ -1259,7 +1259,9 @@ rb_alias(VALUE klass, ID name, ID def) https://github.com/ruby/ruby/blob/trunk/ruby_2_1/vm_method.c#L1259 again: orig_me = search_method(klass, def, &defined_class); - if (UNDEFINED_METHOD_ENTRY_P(orig_me)) { + if (UNDEFINED_METHOD_ENTRY_P(orig_me) || + (orig_me->def->type == VM_METHOD_TYPE_REFINED && + UNDEFINED_METHOD_ENTRY_P(orig_me->def->body.orig_me))) { if ((!RB_TYPE_P(klass, T_MODULE)) || (orig_me = search_method(rb_cObject, def, 0), UNDEFINED_METHOD_ENTRY_P(orig_me))) { Index: ruby_2_1/version.h =================================================================== --- ruby_2_1/version.h (revision 49786) +++ ruby_2_1/version.h (revision 49787) @@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_1/version.h#L1 #define RUBY_VERSION "2.1.5" #define RUBY_RELEASE_DATE "2015-03-01" -#define RUBY_PATCHLEVEL 304 +#define RUBY_PATCHLEVEL 305 #define RUBY_RELEASE_YEAR 2015 #define RUBY_RELEASE_MONTH 3 Index: ruby_2_1/test/ruby/test_refinement.rb =================================================================== --- ruby_2_1/test/ruby/test_refinement.rb (revision 49786) +++ ruby_2_1/test/ruby/test_refinement.rb (revision 49787) @@ -1181,6 +1181,31 @@ class TestRefinement < Test::Unit::TestC https://github.com/ruby/ruby/blob/trunk/ruby_2_1/test/ruby/test_refinement.rb#L1181 end; end + def test_alias_refined_method + assert_separately([], <<-"end;") + bug10731 = '[ruby-core:67523] [Bug #10731]' + + class C + end + + module RefinementBug + refine C do + def foo + end + + def bar + end + end + end + + assert_raise(NameError, bug10731) do + class C + alias foo bar + end + end + end; + end + private def eval_using(mod, s) Property changes on: ruby_2_1 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r49221 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/