[前][次][番号順一覧][スレッド一覧]

ruby-changes:37052

From: nobu <ko1@a...>
Date: Sun, 4 Jan 2015 11:04:42 +0900 (JST)
Subject: [ruby-changes:37052] nobu:r49133 (trunk): unit.rb: no insult method

nobu	2015-01-04 11:04:31 +0900 (Sun, 04 Jan 2015)

  New Revision: 49133

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=49133

  Log:
    unit.rb: no insult method
    
    * test/lib/minitest/unit.rb (i_suck_and_my_tests_are_order_dependent!):
      remove.

  Modified files:
    trunk/test/lib/minitest/unit.rb
    trunk/test/minitest/test_minitest_unit.rb
Index: test/lib/minitest/unit.rb
===================================================================
--- test/lib/minitest/unit.rb	(revision 49132)
+++ test/lib/minitest/unit.rb	(revision 49133)
@@ -1329,18 +1329,6 @@ module MiniTest https://github.com/ruby/ruby/blob/trunk/test/lib/minitest/unit.rb#L1329
       reset
 
       ##
-      # Call this at the top of your tests when you absolutely
-      # positively need to have ordered tests. In doing so, you're
-      # admitting that you suck and your tests are weak.
-
-      def self.i_suck_and_my_tests_are_order_dependent!
-        class << self
-          undef_method :test_order if method_defined? :test_order
-          define_method :test_order do :alpha end
-        end
-      end
-
-      ##
       # Make diffs for this TestCase use #pretty_inspect so that diff
       # in assert_equal can be more details. NOTE: this is much slower
       # than the regular inspect but much more usable for complex
Index: test/minitest/test_minitest_unit.rb
===================================================================
--- test/minitest/test_minitest_unit.rb	(revision 49132)
+++ test/minitest/test_minitest_unit.rb	(revision 49133)
@@ -1648,28 +1648,6 @@ class TestMiniTestUnitTestCase < MiniTes https://github.com/ruby/ruby/blob/trunk/test/minitest/test_minitest_unit.rb#L1648
     assert_equal expected, sample_test_case.test_methods
   end
 
-  def test_i_suck_and_my_tests_are_order_dependent_bang_sets_test_order_alpha
-    @assertion_count = 0
-
-    shitty_test_case = Class.new MiniTest::Unit::TestCase
-
-    shitty_test_case.i_suck_and_my_tests_are_order_dependent!
-
-    assert_equal :alpha, shitty_test_case.test_order
-  end
-
-  def test_i_suck_and_my_tests_are_order_dependent_bang_does_not_warn
-    @assertion_count = 0
-
-    shitty_test_case = Class.new MiniTest::Unit::TestCase
-
-    def shitty_test_case.test_order ; :lol end
-
-    assert_silent do
-      shitty_test_case.i_suck_and_my_tests_are_order_dependent!
-    end
-  end
-
   def util_assert_triggered expected, klass = MiniTest::Assertion
     e = assert_raises klass do
       yield

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]