[前][次][番号順一覧][スレッド一覧]

ruby-changes:37048

From: hsbt <ko1@a...>
Date: Sun, 4 Jan 2015 09:18:49 +0900 (JST)
Subject: [ruby-changes:37048] hsbt:r49129 (trunk): * lib/tempfile.rb: provide default basename parameter.

hsbt	2015-01-04 09:18:38 +0900 (Sun, 04 Jan 2015)

  New Revision: 49129

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=49129

  Log:
    * lib/tempfile.rb: provide default basename parameter.
      [fix GH-523] Patch by @dissolved
    * test/test_tempfile.rb: ditto.

  Modified files:
    trunk/ChangeLog
    trunk/lib/tempfile.rb
    trunk/test/test_tempfile.rb
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 49128)
+++ ChangeLog	(revision 49129)
@@ -1,3 +1,9 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sun Jan  4 09:18:31 2015  SHIBATA Hiroshi  <shibata.hiroshi@g...>
+
+	* lib/tempfile.rb: provide default basename parameter.
+	  [fix GH-523] Patch by @dissolved
+	* test/test_tempfile.rb: ditto.
+
 Sun Jan  4 00:43:41 2015  Ayumu AIZAWA  <ayumu.aizawa@g...>
 
 	* README.ja.md: add guidance of mailing list and bugs.r-l.o.
Index: lib/tempfile.rb
===================================================================
--- lib/tempfile.rb	(revision 49128)
+++ lib/tempfile.rb	(revision 49129)
@@ -122,7 +122,7 @@ class Tempfile < DelegateClass(File) https://github.com/ruby/ruby/blob/trunk/lib/tempfile.rb#L122
   #
   # If Tempfile.new cannot find a unique filename within a limited
   # number of tries, then it will raise an exception.
-  def initialize(basename, tmpdir=nil, mode: 0, **options)
+  def initialize(basename="", tmpdir=nil, mode: 0, **options)
     if block_given?
       warn "Tempfile.new doesn't call the given block."
     end
Index: test/test_tempfile.rb
===================================================================
--- test/test_tempfile.rb	(revision 49128)
+++ test/test_tempfile.rb	(revision 49129)
@@ -57,6 +57,11 @@ class TestTempfile < Test::Unit::TestCas https://github.com/ruby/ruby/blob/trunk/test/test_tempfile.rb#L57
     assert_match(/^foo/, File.basename(t.path))
   end
 
+  def test_default_basename
+    t = tempfile
+    assert File.exist?(t.path)
+  end
+
   def test_basename_with_suffix
     t = tempfile(["foo", ".txt"])
     assert_match(/^foo/, File.basename(t.path))

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]