[前][次][番号順一覧][スレッド一覧]

ruby-changes:36566

From: nobu <ko1@a...>
Date: Sat, 29 Nov 2014 16:15:09 +0900 (JST)
Subject: [ruby-changes:36566] nobu:r48647 (trunk): ruby.h: no parent in rb_data_type_t

nobu	2014-11-29 16:14:53 +0900 (Sat, 29 Nov 2014)

  New Revision: 48647

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=48647

  Log:
    ruby.h: no parent in rb_data_type_t
    
    * error.c (rb_typeddata_is_kind_of, rb_check_typeddata): ditto.
    * error.c (rb_typeddata_inherited_p): deprecate. still keep for
      potential binary compatibility.

  Modified files:
    trunk/ChangeLog
    trunk/error.c
    trunk/include/ruby/ruby.h
Index: include/ruby/ruby.h
===================================================================
--- include/ruby/ruby.h	(revision 48646)
+++ include/ruby/ruby.h	(revision 48647)
@@ -973,7 +973,7 @@ struct rb_data_type_struct { https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L973
 	void *reserved[2]; /* For future extension.
 			      This array *must* be filled with ZERO. */
     } function;
-    const rb_data_type_t *parent;
+    void *const reserved;
     void *data;        /* This area can be used for any purpose
                           by a programmer who define the type. */
     VALUE flags;       /* FL_WB_PROTECTED */
@@ -981,7 +981,6 @@ struct rb_data_type_struct { https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L981
 
 #define HAVE_TYPE_RB_DATA_TYPE_T 1
 #define HAVE_RB_DATA_TYPE_T_FUNCTION 1
-#define HAVE_RB_DATA_TYPE_T_PARENT 1
 
 struct RTypedData {
     struct RBasic basic;
@@ -1010,7 +1009,6 @@ typedef void (*RUBY_DATA_FUNC)(void*); https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L1009
 #endif
 VALUE rb_data_object_alloc(VALUE,void*,RUBY_DATA_FUNC,RUBY_DATA_FUNC);
 VALUE rb_data_typed_object_alloc(VALUE klass, void *datap, const rb_data_type_t *);
-int rb_typeddata_inherited_p(const rb_data_type_t *child, const rb_data_type_t *parent);
 int rb_typeddata_is_kind_of(VALUE, const rb_data_type_t *);
 void *rb_check_typeddata(VALUE, const rb_data_type_t *);
 #define Check_TypedStruct(v,t) rb_check_typeddata((VALUE)(v),(t))
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 48646)
+++ ChangeLog	(revision 48647)
@@ -1,3 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sat Nov 29 16:14:50 2014  Nobuyoshi Nakada  <nobu@r...>
+
+	* error.c (rb_typeddata_is_kind_of, rb_check_typeddata): ditto.
+
+	* error.c (rb_typeddata_inherited_p): deprecate. still keep for
+	  potential binary compatibility.
+
 Sat Nov 29 10:49:23 2014  Nobuyoshi Nakada  <nobu@r...>
 
 	* win32/win32.c (win32_direct_conv, rb_w32_readdir): convert UTF-8
Index: error.c
===================================================================
--- error.c	(revision 48646)
+++ error.c	(revision 48647)
@@ -541,10 +541,8 @@ rb_check_type(VALUE x, int t) https://github.com/ruby/ruby/blob/trunk/error.c#L541
 int
 rb_typeddata_inherited_p(const rb_data_type_t *child, const rb_data_type_t *parent)
 {
-    while (child) {
-	if (child == parent) return 1;
-	child = child->parent;
-    }
+    rb_warn("rb_typeddata_inherited_p() is deprecated");
+    if (child == parent) return 1;
     return 0;
 }
 
@@ -552,7 +550,7 @@ int https://github.com/ruby/ruby/blob/trunk/error.c#L550
 rb_typeddata_is_kind_of(VALUE obj, const rb_data_type_t *data_type)
 {
     if (!RB_TYPE_P(obj, T_DATA) ||
-	!RTYPEDDATA_P(obj) || !rb_typeddata_inherited_p(RTYPEDDATA_TYPE(obj), data_type)) {
+	!RTYPEDDATA_P(obj) || RTYPEDDATA_TYPE(obj) != data_type) {
 	return 0;
     }
     return 1;
@@ -572,7 +570,7 @@ rb_check_typeddata(VALUE obj, const rb_d https://github.com/ruby/ruby/blob/trunk/error.c#L570
 	etype = rb_obj_classname(obj);
 	rb_raise(rb_eTypeError, mesg, etype, data_type->wrap_struct_name);
     }
-    else if (!rb_typeddata_inherited_p(RTYPEDDATA_TYPE(obj), data_type)) {
+    else if (RTYPEDDATA_TYPE(obj) != data_type) {
 	etype = RTYPEDDATA_TYPE(obj)->wrap_struct_name;
 	rb_raise(rb_eTypeError, mesg, etype, data_type->wrap_struct_name);
     }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]