ruby-changes:36325
From: usa <ko1@a...>
Date: Thu, 13 Nov 2014 22:39:49 +0900 (JST)
Subject: [ruby-changes:36325] usa:r48406 (ruby_1_9_3): merge revision(s) 48402:
usa 2014-11-13 22:39:32 +0900 (Thu, 13 Nov 2014) New Revision: 48406 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=48406 Log: merge revision(s) 48402: * lib/rexml/document.rb: add REXML::Document#document. reported by Tomas Hoger <thoger@r...> and patched by nahi. Modified directories: branches/ruby_1_9_3/ Modified files: branches/ruby_1_9_3/ChangeLog branches/ruby_1_9_3/lib/rexml/document.rb branches/ruby_1_9_3/lib/rexml/entity.rb branches/ruby_1_9_3/test/rexml/test_document.rb branches/ruby_1_9_3/version.h Index: ruby_1_9_3/ChangeLog =================================================================== --- ruby_1_9_3/ChangeLog (revision 48405) +++ ruby_1_9_3/ChangeLog (revision 48406) @@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/ChangeLog#L1 +Thu Nov 13 22:36:17 2014 CHIKANAGA Tomoyuki <nagachika@r...> + + * lib/rexml/document.rb: add REXML::Document#document. + reported by Tomas Hoger <thoger@r...> and patched by nahi. + Mon Oct 27 20:23:27 2014 NAKAMURA Usaku <usa@r...> * lib/rexml/entity.rb: keep the entity size within the limitation. Index: ruby_1_9_3/lib/rexml/document.rb =================================================================== --- ruby_1_9_3/lib/rexml/document.rb (revision 48405) +++ ruby_1_9_3/lib/rexml/document.rb (revision 48406) @@ -240,6 +240,10 @@ module REXML https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/lib/rexml/document.rb#L240 end end + def document + self + end + private def build( source ) Parsers::TreeParser.new( source, self ).parse Index: ruby_1_9_3/lib/rexml/entity.rb =================================================================== --- ruby_1_9_3/lib/rexml/entity.rb (revision 48405) +++ ruby_1_9_3/lib/rexml/entity.rb (revision 48406) @@ -157,6 +157,7 @@ module REXML https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/lib/rexml/entity.rb#L157 # This is a set of entity constants -- the ones defined in the XML # specification. These are +gt+, +lt+, +amp+, +quot+ and +apos+. + # CAUTION: these entities does not have parent and document module EntityConst # +>+ GT = Entity.new( 'gt', '>' ) Index: ruby_1_9_3/version.h =================================================================== --- ruby_1_9_3/version.h (revision 48405) +++ ruby_1_9_3/version.h (revision 48406) @@ -1,10 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/version.h#L1 #define RUBY_VERSION "1.9.3" -#define RUBY_PATCHLEVEL 550 +#define RUBY_PATCHLEVEL 551 -#define RUBY_RELEASE_DATE "2014-10-27" +#define RUBY_RELEASE_DATE "2014-11-13" #define RUBY_RELEASE_YEAR 2014 -#define RUBY_RELEASE_MONTH 10 -#define RUBY_RELEASE_DAY 27 +#define RUBY_RELEASE_MONTH 11 +#define RUBY_RELEASE_DAY 13 #include "ruby/version.h" Index: ruby_1_9_3/test/rexml/test_document.rb =================================================================== --- ruby_1_9_3/test/rexml/test_document.rb (revision 48405) +++ ruby_1_9_3/test/rexml/test_document.rb (revision 48406) @@ -47,6 +47,22 @@ EOF https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/test/rexml/test_document.rb#L47 </member> EOF + XML_WITH_NESTED_EMPTY_ENTITY = <<EOF +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE member [ + <!ENTITY a "&b;&b;&b;&b;&b;&b;&b;&b;&b;&b;"> + <!ENTITY b "&c;&c;&c;&c;&c;&c;&c;&c;&c;&c;"> + <!ENTITY c "&d;&d;&d;&d;&d;&d;&d;&d;&d;&d;"> + <!ENTITY d "&e;&e;&e;&e;&e;&e;&e;&e;&e;&e;"> + <!ENTITY e "&f;&f;&f;&f;&f;&f;&f;&f;&f;&f;"> + <!ENTITY f "&g;&g;&g;&g;&g;&g;&g;&g;&g;&g;"> + <!ENTITY g ""> +]> +<member> +&a; +</member> +EOF + XML_WITH_NESTED_PARAMETER_ENTITY = <<EOF <!DOCTYPE root [ <!ENTITY % a "BOOM.BOOM.BOOM.BOOM.BOOM.BOOM.BOOM.BOOM.BOOM."> @@ -57,7 +73,21 @@ EOF https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/test/rexml/test_document.rb#L73 <!ENTITY % f "%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;"> <!ENTITY % g "%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;"> <!ENTITY test "test %g;"> -+]> +]> +<cd></cd> +EOF + + XML_WITH_NESTED_EMPTY_PARAMETER_ENTITY = <<EOF +<!DOCTYPE root [ + <!ENTITY % a ""> + <!ENTITY % b "%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;%a;"> + <!ENTITY % c "%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;%b;"> + <!ENTITY % d "%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;%c;"> + <!ENTITY % e "%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;%d;"> + <!ENTITY % f "%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;%e;"> + <!ENTITY % g "%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;%f;"> + <!ENTITY test "test %g;"> +]> <cd></cd> EOF @@ -87,6 +117,18 @@ EOF https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/test/rexml/test_document.rb#L117 end assert_equal(101, doc.entity_expansion_count) + doc = REXML::Document.new(XML_WITH_NESTED_EMPTY_ENTITY) + assert_raise(RuntimeError) do + doc.root.children.first.value + end + REXML::Document.entity_expansion_limit = 100 + assert_equal(100, REXML::Document.entity_expansion_limit) + doc = REXML::Document.new(XML_WITH_NESTED_EMPTY_ENTITY) + assert_raise(RuntimeError) do + doc.root.children.first.value + end + assert_equal(101, doc.entity_expansion_count) + REXML::Document.entity_expansion_limit = 4 doc = REXML::Document.new(XML_WITH_4_ENTITY_EXPANSION) assert_equal("\na\na a\n<\n", doc.root.children.first.value) @@ -95,6 +137,15 @@ EOF https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/test/rexml/test_document.rb#L137 assert_raise(RuntimeError) do doc.root.children.first.value end + + assert_raise(REXML::ParseException) do + REXML::Document.new(XML_WITH_NESTED_EMPTY_PARAMETER_ENTITY) + end + REXML::Document.entity_expansion_limit = 100 + assert_equal(100, REXML::Document.entity_expansion_limit) + assert_raise(REXML::ParseException) do + REXML::Document.new(XML_WITH_NESTED_EMPTY_PARAMETER_ENTITY) + end ensure REXML::Document.entity_expansion_limit = 10000 end Property changes on: ruby_1_9_3 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r48402 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/