ruby-changes:36105
From: nobu <ko1@a...>
Date: Wed, 29 Oct 2014 14:44:43 +0900 (JST)
Subject: [ruby-changes:36105] nobu:r48186 (trunk): load.c: transcode path
nobu 2014-10-29 14:44:33 +0900 (Wed, 29 Oct 2014) New Revision: 48186 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=48186 Log: load.c: transcode path * load.c (rb_f_load): path name needs to be transcoded to OS path encoding. [ruby-list:49994] Modified files: trunk/ChangeLog trunk/load.c trunk/test/ruby/test_require.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 48185) +++ ChangeLog (revision 48186) @@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1 +Wed Oct 29 14:44:27 2014 Nobuyoshi Nakada <nobu@r...> + + * load.c (rb_f_load): path name needs to be transcoded to OS path + encoding. [ruby-list:49994] + Wed Oct 29 11:48:23 2014 Nobuyoshi Nakada <nobu@r...> * configure.in (__builtin_setjmp): disable with gcc/clang earlier Index: load.c =================================================================== --- load.c (revision 48185) +++ load.c (revision 48186) @@ -683,7 +683,7 @@ rb_load_protect(VALUE fname, int wrap, i https://github.com/ruby/ruby/blob/trunk/load.c#L683 static VALUE rb_f_load(int argc, VALUE *argv) { - VALUE fname, wrap, path; + VALUE fname, wrap, path, orig_fname; rb_scan_args(argc, argv, "11", &fname, &wrap); @@ -693,10 +693,12 @@ rb_f_load(int argc, VALUE *argv) https://github.com/ruby/ruby/blob/trunk/load.c#L693 rb_sourceline()); } - path = rb_find_file(FilePathValue(fname)); + orig_fname = FilePathValue(fname); + fname = rb_str_encode_ospath(orig_fname); + path = rb_find_file(fname); if (!path) { if (!rb_file_load_ok(RSTRING_PTR(fname))) - load_failed(fname); + load_failed(orig_fname); path = fname; } rb_load_internal(path, RTEST(wrap)); Index: test/ruby/test_require.rb =================================================================== --- test/ruby/test_require.rb (revision 48185) +++ test/ruby/test_require.rb (revision 48186) @@ -308,6 +308,28 @@ class TestRequire < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_require.rb#L308 } end + def test_load_ospath + bug = '[ruby-list:49994] path in ospath' + base = "test_load\u{3042 3044 3046 3048 304a}".encode(Encoding::Windows_31J) + path = nil + Tempfile.create([base, ".rb"]) do |t| + path = t.path + + assert_raise_with_message(LoadError, /#{base}/) { + load(File.join(File.dirname(path), base)) + } + + t.puts "warn 'ok'" + t.close + assert_include(path, base) + assert_warn("ok\n", bug) { + assert_nothing_raised(LoadError, bug) { + load(path) + } + } + end + end + def test_tainted_loadpath Tempfile.create(["test_ruby_test_require", ".rb"]) {|t| abs_dir, file = File.split(t.path) -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/