ruby-changes:35252
From: usa <ko1@a...>
Date: Sun, 31 Aug 2014 16:19:17 +0900 (JST)
Subject: [ruby-changes:35252] usa:r47334 (ruby_2_0_0): merge revision(s) 46344: [Backport #9902]
usa 2014-08-31 16:19:09 +0900 (Sun, 31 Aug 2014) New Revision: 47334 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=47334 Log: merge revision(s) 46344: [Backport #9902] * re.c (match_aref): should not ignore name after NUL byte. [ruby-dev:48275] [Bug #9902] Modified directories: branches/ruby_2_0_0/ Modified files: branches/ruby_2_0_0/ChangeLog branches/ruby_2_0_0/re.c branches/ruby_2_0_0/test/ruby/test_regexp.rb branches/ruby_2_0_0/version.h Index: ruby_2_0_0/ChangeLog =================================================================== --- ruby_2_0_0/ChangeLog (revision 47333) +++ ruby_2_0_0/ChangeLog (revision 47334) @@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_0_0/ChangeLog#L1 +Sun Aug 31 16:16:24 2014 Nobuyoshi Nakada <nobu@r...> + + * re.c (match_aref): should not ignore name after NUL byte. + [ruby-dev:48275] [Bug #9902] + Sun Aug 31 16:10:30 2014 Nobuyoshi Nakada <nobu@r...> * ext/digest/digest.c (rb_digest_instance_equal): no need to call Index: ruby_2_0_0/re.c =================================================================== --- ruby_2_0_0/re.c (revision 47333) +++ ruby_2_0_0/re.c (revision 47334) @@ -1728,17 +1728,13 @@ match_aref(int argc, VALUE *argv, VALUE https://github.com/ruby/ruby/blob/trunk/ruby_2_0_0/re.c#L1728 switch (TYPE(idx)) { case T_SYMBOL: - p = rb_id2name(SYM2ID(idx)); - goto name_to_backref; - break; + idx = rb_id2str(SYM2ID(idx)); + /* fall through */ case T_STRING: p = StringValuePtr(idx); - - name_to_backref: num = name_to_backref_number(RMATCH_REGS(match), - RMATCH(match)->regexp, p, p + strlen(p)); + RMATCH(match)->regexp, p, p + RSTRING_LEN(idx)); return rb_reg_nth_match(num, match); - break; default: break; Index: ruby_2_0_0/version.h =================================================================== --- ruby_2_0_0/version.h (revision 47333) +++ ruby_2_0_0/version.h (revision 47334) @@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_0_0/version.h#L1 #define RUBY_VERSION "2.0.0" #define RUBY_RELEASE_DATE "2014-08-31" -#define RUBY_PATCHLEVEL 534 +#define RUBY_PATCHLEVEL 535 #define RUBY_RELEASE_YEAR 2014 #define RUBY_RELEASE_MONTH 8 Index: ruby_2_0_0/test/ruby/test_regexp.rb =================================================================== --- ruby_2_0_0/test/ruby/test_regexp.rb (revision 47333) +++ ruby_2_0_0/test/ruby/test_regexp.rb (revision 47334) @@ -134,6 +134,22 @@ class TestRegexp < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/ruby_2_0_0/test/ruby/test_regexp.rb#L134 assert_equal("fbazo", s) end + def test_named_capture_with_nul + bug9902 = '[ruby-dev:48275] [Bug #9902]' + + m = /(?<a>.*)/.match("foo") + assert_raise(IndexError, bug9902) {m["a\0foo"]} + assert_raise(IndexError, bug9902) {m["a\0foo".to_sym]} + + m = Regexp.new("(?<foo\0bar>.*)").match("xxx") + assert_raise(IndexError, bug9902) {m["foo"]} + assert_raise(IndexError, bug9902) {m["foo".to_sym]} + assert_nothing_raised(IndexError, bug9902) { + assert_equal("xxx", m["foo\0bar"], bug9902) + assert_equal("xxx", m["foo\0bar".to_sym], bug9902) + } + end + def test_assign_named_capture assert_equal("a", eval('/(?<foo>.)/ =~ "a"; foo')) assert_equal("a", eval('foo = 1; /(?<foo>.)/ =~ "a"; foo')) Property changes on: ruby_2_0_0 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r46344 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/