[前][次][番号順一覧][スレッド一覧]

ruby-changes:35171

From: ko1 <ko1@a...>
Date: Fri, 22 Aug 2014 20:24:49 +0900 (JST)
Subject: [ruby-changes:35171] ko1:r47253 (trunk): * string.c (rb_fstring): fix condition (easy to cause infinite loop!).

ko1	2014-08-22 20:24:38 +0900 (Fri, 22 Aug 2014)

  New Revision: 47253

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=47253

  Log:
    * string.c (rb_fstring): fix condition (easy to cause infinite loop!).

  Modified files:
    trunk/ChangeLog
    trunk/string.c
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 47252)
+++ ChangeLog	(revision 47253)
@@ -1,3 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Fri Aug 22 20:23:54 2014  Koichi Sasada  <ko1@a...>
+
+	* string.c (rb_fstring): fix condition (easy to cause infinite loop!).
+
 Fri Aug 22 20:07:43 2014  Koichi Sasada  <ko1@a...>
 
 	* string.c (rb_fstring, fstr_update_callback): simply delete garbage
@@ -17,7 +21,7 @@ Fri Aug 22 19:30:39 2014  SHIBATA Hirosh https://github.com/ruby/ruby/blob/trunk/ChangeLog#L21
 
 Fri Aug 22 19:25:28 2014  SHIBATA Hiroshi  <shibata.hiroshi@g...>
 
-	* test/ruby/test_complex.rb: fixed broken tests. Math is not
+	* test/ruby/test_complex.rb: fixed broken tests. Math is nota
 	  compatible CMath now.
 
 Fri Aug 22 15:36:09 2014  Nobuyoshi Nakada  <nobu@r...>
Index: string.c
===================================================================
--- string.c	(revision 47252)
+++ string.c	(revision 47253)
@@ -232,7 +232,7 @@ rb_fstring(VALUE str) https://github.com/ruby/ruby/blob/trunk/string.c#L232
     do {
 	ret = str;
 	st_update(frozen_strings, (st_data_t)str, fstr_update_callback, (st_data_t)&ret);
-    } while (ret != Qundef);
+    } while (ret == Qundef);
 
     return ret;
 }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]