[前][次][番号順一覧][スレッド一覧]

ruby-changes:32861

From: usa <ko1@a...>
Date: Fri, 14 Feb 2014 15:06:19 +0900 (JST)
Subject: [ruby-changes:32861] usa:r44940 (ruby_1_9_3): merge revision(s) 44670, 44671, 44675: [Backport #8783]

usa	2014-02-14 15:06:14 +0900 (Fri, 14 Feb 2014)

  New Revision: 44940

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=44940

  Log:
    merge revision(s) 44670,44671,44675: [Backport #8783]
    
    thread_pthread.c: timer thread stack size
    
    * thread_pthread.c (rb_thread_create_timer_thread): define the stack
      size for timer thread at compile time.
    * thread_pthread.c (rb_thread_create_timer_thread): expand timer
      thread stack size to get rid of segfault on FreeBSD/powerpc64.
      based on the patch by Steve Wills at [ruby-core:59923].
      [ruby-core:56590] [Bug #8783]
    
    * thread_pthread.c (rb_thread_create_timer_thread): fix for platforms
      where PTHREAD_STACK_MIN is a dynamic value and not a compile-time
      constant.  [ruby-dev:47911] [Bug #9436]

  Modified directories:
    branches/ruby_1_9_3/
  Modified files:
    branches/ruby_1_9_3/ChangeLog
    branches/ruby_1_9_3/thread_pthread.c
    branches/ruby_1_9_3/version.h
Index: ruby_1_9_3/ChangeLog
===================================================================
--- ruby_1_9_3/ChangeLog	(revision 44939)
+++ ruby_1_9_3/ChangeLog	(revision 44940)
@@ -1,3 +1,16 @@ https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/ChangeLog#L1
+Fri Feb 14 15:04:36 2014  Nobuyoshi Nakada  <nobu@r...>
+
+	* thread_pthread.c (rb_thread_create_timer_thread): fix for platforms
+	  where PTHREAD_STACK_MIN is a dynamic value and not a compile-time
+	  constant.  [ruby-dev:47911] [Bug #9436]
+
+Fri Feb 14 15:04:36 2014  Nobuyoshi Nakada  <nobu@r...>
+
+	* thread_pthread.c (rb_thread_create_timer_thread): expand timer
+	  thread stack size to get rid of segfault on FreeBSD/powerpc64.
+	  based on the patch by Steve Wills at [ruby-core:59923].
+	  [ruby-core:56590] [Bug #8783]
+
 Fri Feb 14 14:58:19 2014  Nobuyoshi Nakada  <nobu@r...>
 
 	* eval.c (rb_mod_s_constants): return its own constants for other
Index: ruby_1_9_3/thread_pthread.c
===================================================================
--- ruby_1_9_3/thread_pthread.c	(revision 44939)
+++ ruby_1_9_3/thread_pthread.c	(revision 44940)
@@ -1193,17 +1193,16 @@ rb_thread_create_timer_thread(void) https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/thread_pthread.c#L1193
 
 	pthread_attr_init(&attr);
 #ifdef PTHREAD_STACK_MIN
-	if (PTHREAD_STACK_MIN < 4096 * 3) {
+	{
+	    const size_t min_size = (4096 * 4);
 	    /* Allocate the machine stack for the timer thread
-             * at least 12KB (3 pages).  FreeBSD 8.2 AMD64 causes
-             * machine stack overflow only with PTHREAD_STACK_MIN.
+	     * at least 16KB (4 pages).  FreeBSD 8.2 AMD64 causes
+	     * machine stack overflow only with PTHREAD_STACK_MIN.
 	     */
-	    pthread_attr_setstacksize(&attr,
-				      4096 * 3 + (THREAD_DEBUG ? BUFSIZ : 0));
-	}
-	else {
-	    pthread_attr_setstacksize(&attr,
-				      PTHREAD_STACK_MIN + (THREAD_DEBUG ? BUFSIZ : 0));
+	    size_t stack_size = PTHREAD_STACK_MIN; /* may be dynamic, get only once */
+	    if (stack_size < min_size) stack_size = min_size;
+	    if (THREAD_DEBUG) stack_size += BUFSIZ;
+	    pthread_attr_setstacksize(&attr, stack_size);
 	}
 #endif
 
Index: ruby_1_9_3/version.h
===================================================================
--- ruby_1_9_3/version.h	(revision 44939)
+++ ruby_1_9_3/version.h	(revision 44940)
@@ -1,5 +1,5 @@ https://github.com/ruby/ruby/blob/trunk/ruby_1_9_3/version.h#L1
 #define RUBY_VERSION "1.9.3"
-#define RUBY_PATCHLEVEL 521
+#define RUBY_PATCHLEVEL 522
 
 #define RUBY_RELEASE_DATE "2014-02-14"
 #define RUBY_RELEASE_YEAR 2014

Property changes on: ruby_1_9_3
___________________________________________________________________
Modified: svn:mergeinfo
   Merged /trunk:r44670-44671,44675


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]