nobu	2013-12-24 16:28:11 +0900 (Tue, 24 Dec 2013)

  New Revision: 44380

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=44380

  Log:
    proc.c: make method by define_method public
    
    * proc.c (rb_mod_define_method): consider visibility only if self
      in the caller is same as the receiver, otherwise make public as
      well as old behavior.  [ruby-core:57747] [Bug #9005]
      [ruby-core:58497] [Bug #9141]
    * vm.c (rb_vm_cref_in_context): return ruby level cref if self is
      same.

  Modified files:
    trunk/ChangeLog
    trunk/proc.c
    trunk/test/ruby/test_method.rb
    trunk/vm.c
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 44379)
+++ ChangeLog	(revision 44380)
@@ -1,3 +1,13 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Tue Dec 24 16:28:05 2013  Nobuyoshi Nakada  <nobu@r...>
+
+	* proc.c (rb_mod_define_method): consider visibility only if self
+	  in the caller is same as the receiver, otherwise make public as
+	  well as old behavior.  [ruby-core:57747] [Bug #9005]
+	  [ruby-core:58497] [Bug #9141]
+
+	* vm.c (rb_vm_cref_in_context): return ruby level cref if self is
+	  same.
+
 Tue Dec 24 14:13:14 2013  Koichi Sasada  <ko1@a...>
 
 	* README.EXT: add a refer to URL.
Index: proc.c
===================================================================
--- proc.c	(revision 44379)
+++ proc.c	(revision 44380)
@@ -14,6 +14,8 @@ https://github.com/ruby/ruby/blob/trunk/proc.c#L14
 #include "gc.h"
 #include "iseq.h"
 
+NODE *rb_vm_cref_in_context(VALUE self);
+
 struct METHOD {
     VALUE recv;
     VALUE rclass;
@@ -1619,7 +1621,12 @@ rb_mod_define_method(int argc, VALUE *ar https://github.com/ruby/ruby/blob/trunk/proc.c#L1621
 {
     ID id;
     VALUE body;
-    int noex = (int)rb_vm_cref()->nd_visi;
+    int noex = NOEX_PUBLIC;
+    const NODE *cref = rb_vm_cref_in_context(mod);
+
+    if (cref && cref->nd_clss == mod) {
+	noex = (int)cref->nd_visi;
+    }
 
     if (argc == 1) {
 	id = rb_to_id(argv[0]);
Index: vm.c
===================================================================
--- vm.c	(revision 44379)
+++ vm.c	(revision 44380)
@@ -930,6 +930,15 @@ rb_vm_cref(void) https://github.com/ruby/ruby/blob/trunk/vm.c#L930
     return rb_vm_get_cref(cfp->iseq, cfp->ep);
 }
 
+NODE *
+rb_vm_cref_in_context(VALUE self)
+{
+    rb_thread_t *th = GET_THREAD();
+    const rb_control_frame_t *cfp = rb_vm_get_ruby_level_next_cfp(th, th->cfp);
+    if (cfp->self != self) return NULL;
+    return rb_vm_get_cref(cfp->iseq, cfp->ep);
+}
+
 #if 0
 void
 debug_cref(NODE *cref)
Index: test/ruby/test_method.rb
===================================================================
--- test/ruby/test_method.rb	(revision 44379)
+++ test/ruby/test_method.rb	(revision 44380)
@@ -338,6 +338,29 @@ class TestMethod < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_method.rb#L338
     assert_equal(true, m.private_method_defined?(:foo))
   end
 
+  def test_define_method_in_private_scope
+    bug9005 = '[ruby-core:57747] [Bug #9005]'
+    c = Class.new
+    class << c
+      public :define_method
+    end
+    TOPLEVEL_BINDING.eval("proc{|c|c.define_method(:x) {|*x|throw x}}").call(c)
+    o = c.new
+    assert_throw(bug9005) {o.x(bug9005)}
+  end
+
+  def test_singleton_define_method_in_private_scope
+    bug9141 = '[ruby-core:58497] [Bug #9141]'
+    o = Object.new
+    class << o
+      public :define_singleton_method
+    end
+    TOPLEVEL_BINDING.eval("proc{|o|o.define_singleton_method(:x) {|x|throw x}}").call(o)
+    assert_throw(bug9141) do
+      o.x(bug9141)
+    end
+  end
+
   def test_super_in_proc_from_define_method
     c1 = Class.new {
       def m

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/