akr	2013-08-16 00:36:00 +0900 (Fri, 16 Aug 2013)

  New Revision: 42570

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=42570

  Log:
    * bignum.c (rb_big2str1): Truncate topmost zeros of x.

  Modified files:
    trunk/ChangeLog
    trunk/bignum.c
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 42569)
+++ ChangeLog	(revision 42570)
@@ -1,3 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Fri Aug 16 00:33:12 2013  Tanaka Akira  <akr@f...>
+
+	* bignum.c (rb_big2str1): Truncate topmost zeros of x.
+
 Fri Aug 16 00:00:57 2013  Tanaka Akira  <akr@f...>
 
 	* bignum.c (bary_divmod): Simplify an expression.
Index: bignum.c
===================================================================
--- bignum.c	(revision 42569)
+++ bignum.c	(revision 42570)
@@ -4497,18 +4497,25 @@ rb_big2str1(VALUE x, int base) https://github.com/ruby/ruby/blob/trunk/bignum.c#L4497
     struct big2str_struct b2s_data;
     int power_level;
     VALUE power;
+    BDIGIT *xds;
+    size_t xn;
 
     if (FIXNUM_P(x)) {
 	return rb_fix2str(x, base);
     }
-    if (BIGZEROP(x)) {
+
+    xds = BDIGITS(x);
+    xn = RBIGNUM_LEN(x);
+    BARY_TRUNC(xds, xn);
+
+    if (xn == 0) {
 	return rb_usascii_str_new2("0");
     }
 
     if (base < 2 || 36 < base)
 	rb_raise(rb_eArgError, "invalid radix %d", base);
 
-    if (RBIGNUM_LEN(x) >= LONG_MAX/BITSPERDIG) {
+    if (xn >= LONG_MAX/BITSPERDIG) {
         rb_raise(rb_eRangeError, "bignum too big to convert into `string'");
     }
 
@@ -4520,13 +4527,13 @@ rb_big2str1(VALUE x, int base) https://github.com/ruby/ruby/blob/trunk/bignum.c#L4527
     power_level = 0;
     power = power_cache_get_power(base, power_level, NULL);
     while (power_level < MAX_BASE36_POWER_TABLE_ENTRIES &&
-           RBIGNUM_LEN(power) <= (RBIGNUM_LEN(x)+1)/2) {
+           (size_t)RBIGNUM_LEN(power) <= (xn+1)/2) {
         power_level++;
         power = power_cache_get_power(base, power_level, NULL);
     }
     assert(power_level != MAX_BASE36_POWER_TABLE_ENTRIES);
 
-    if (RBIGNUM_LEN(power) <= RBIGNUM_LEN(x)) {
+    if ((size_t)RBIGNUM_LEN(power) <= xn) {
         /*
          * This increment guarantees x < power_cache_get_power(base, power_level)
          * without invoking it actually.
@@ -4549,19 +4556,18 @@ rb_big2str1(VALUE x, int base) https://github.com/ruby/ruby/blob/trunk/bignum.c#L4556
     b2s_data.ptr = NULL;
 
     if (power_level == 0) {
-	big2str_orig(&b2s_data, BDIGITS(x), RBIGNUM_LEN(x), 0);
+	big2str_orig(&b2s_data, xds, xn, 0);
     }
     else {
-        VALUE tmpx = 0;
-        BDIGIT *xds;
-        size_t xn, wn;
-        xn = RBIGNUM_LEN(x);
+        VALUE tmpw = 0;
+        BDIGIT *wds;
+        size_t wn;
         wn = bitsize(xn) + 1 + RBIGNUM_LEN(power);
-        xds = ALLOCV_N(BDIGIT, tmpx, xn + wn);
-        MEMCPY(xds, BDIGITS(x), BDIGIT, xn);
-	big2str_karatsuba(&b2s_data, xds, xn, wn, power_level, 0);
-        if (tmpx)
-            ALLOCV_END(tmpx);
+        wds = ALLOCV_N(BDIGIT, tmpw, xn + wn);
+        MEMCPY(wds, xds, BDIGIT, xn);
+	big2str_karatsuba(&b2s_data, wds, xn, wn, power_level, 0);
+        if (tmpw)
+            ALLOCV_END(tmpw);
     }
     RB_GC_GUARD(x);
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/