kosaki	2013-03-10 12:59:29 +0900 (Sun, 10 Mar 2013)

  New Revision: 39681

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=39681

  Log:
    * thread_pthread.c (timer_thread_sleep): use poll() instead of
      select(). select doesn't work if timer_thread_pipe[0] is
      greater than FD_SETSIZE.
    * thread_pthread.c (USE_SLEEPY_TIMER_THREAD): add a dependency
      against poll.

  Modified files:
    trunk/ChangeLog
    trunk/thread_pthread.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 39680)
+++ ChangeLog	(revision 39681)
@@ -1,3 +1,11 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Wed Mar  6 21:31:35 2013  KOSAKI Motohiro  <kosaki.motohiro@g...>
+
+	* thread_pthread.c (timer_thread_sleep): use poll() instead of
+	  select(). select doesn't work if timer_thread_pipe[0] is
+	  greater than FD_SETSIZE.
+	* thread_pthread.c (USE_SLEEPY_TIMER_THREAD): add a dependency
+	  against poll.
+
 Wed Mar  6 21:00:23 2013  KOSAKI Motohiro  <kosaki.motohiro@g...>
 
 	* thread_pthread.c (USE_SLEEPY_TIMER_THREAD): use more accurate
Index: thread_pthread.c
===================================================================
--- thread_pthread.c	(revision 39680)
+++ thread_pthread.c	(revision 39681)
@@ -30,6 +30,9 @@ https://github.com/ruby/ruby/blob/trunk/thread_pthread.c#L30
 #if defined(__native_client__) && defined(NACL_NEWLIB)
 # include "nacl/select.h"
 #endif
+#if HAVE_POLL
+#include <poll.h>
+#endif
 
 static void native_mutex_lock(pthread_mutex_t *lock);
 static void native_mutex_unlock(pthread_mutex_t *lock);
@@ -53,11 +56,10 @@ static pthread_t timer_thread_id; https://github.com/ruby/ruby/blob/trunk/thread_pthread.c#L56
 #define USE_MONOTONIC_COND 0
 #endif
 
-#if defined(HAVE_FCNTL) && defined(F_GETFL) && defined(F_SETFL) && defined(O_NONBLOCK) && !defined(__native_client__)
+#if defined(HAVE_POLL) && defined(HAVE_FCNTL) && defined(F_GETFL) && defined(F_SETFL) && defined(O_NONBLOCK) && !defined(__native_client__)
 /* The timer thread sleeps while only one Ruby thread is running. */
 # define USE_SLEEPY_TIMER_THREAD 1
 #else
-/* Doesn't have select(1). */
 # define USE_SLEEPY_TIMER_THREAD 0
 #endif
 
@@ -1218,23 +1220,20 @@ timer_thread_sleep(rb_global_vm_lock_t* https://github.com/ruby/ruby/blob/trunk/thread_pthread.c#L1220
 {
     int result;
     int need_polling;
-    struct timeval timeout;
-    fd_set rfds;
-    FD_ZERO(&rfds);
-    FD_SET(timer_thread_pipe[0], &rfds);
+    struct pollfd pollfd;
+
+    pollfd.fd = timer_thread_pipe[0];
+    pollfd.events = POLLIN;
 
     need_polling = check_signal_thread_list();
 
     if (gvl->waiting > 0 || need_polling) {
-	timeout.tv_sec = 0;
-	timeout.tv_usec = TIME_QUANTUM_USEC;
-
 	/* polling (TIME_QUANTUM_USEC usec) */
-	result = select(timer_thread_pipe[0] + 1, &rfds, 0, 0, &timeout);
+	result = poll(&pollfd, 1, TIME_QUANTUM_USEC/1000);
     }
     else {
 	/* wait (infinite) */
-	result = select(timer_thread_pipe[0] + 1, &rfds, 0, 0, 0);
+	result = poll(&pollfd, 1, -1);
     }
 
     if (result == 0) {

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/