ruby-changes:26405
From: naruse <ko1@a...>
Date: Wed, 19 Dec 2012 11:25:55 +0900 (JST)
Subject: [ruby-changes:26405] naruse:r38455 (trunk): Revert r38371 and r38384. they didn't solve the issue
naruse 2012-12-19 11:25:40 +0900 (Wed, 19 Dec 2012) New Revision: 38455 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=38455 Log: Revert r38371 and r38384. they didn't solve the issue Modified files: trunk/ChangeLog trunk/vm_trace.c Index: ChangeLog =================================================================== --- ChangeLog (revision 38454) +++ ChangeLog (revision 38455) @@ -414,12 +414,6 @@ Fri Dec 14 13:58:40 2012 Eric Hodel <d https://github.com/ruby/ruby/blob/trunk/ChangeLog#L414 * lib/rubygems/rdoc.rb: Reduced diff with RDoc::RubyGemsHook * test/rubygems/test_gem_rdoc.rb: ditto -Fri Dec 14 10:36:10 2012 NARUSE, Yui <naruse@r...> - - * vm_trace.c (exec_hooks): add volatile to avoid segv. - On test-all with -j, it may crash in TH_POP_TAG. - Detailed mechanism is not known but this fixes it. - Fri Dec 14 04:08:05 2012 NARUSE, Yui <naruse@r...> * test/ruby/envutil.rb (Test::Unit::Assertions#assert_separately): Index: vm_trace.c =================================================================== --- vm_trace.c (revision 38454) +++ vm_trace.c (revision 38455) @@ -244,7 +244,7 @@ clean_hooks(rb_hook_list_t *list) https://github.com/ruby/ruby/blob/trunk/vm_trace.c#L244 static int exec_hooks(rb_thread_t *th, rb_hook_list_t *list, const rb_trace_arg_t *trace_arg, int can_clean_hooks) { - volatile int state; + int state; volatile int raised; if (UNLIKELY(list->need_clean > 0) && can_clean_hooks) { @@ -275,10 +275,6 @@ exec_hooks(rb_thread_t *th, rb_hook_list https://github.com/ruby/ruby/blob/trunk/vm_trace.c#L275 if (raised) { rb_threadptr_set_raised(th); } - { - /* maybe rb_thread_t *volatile? */ - rb_thread_t volatile *RB_UNUSED_VAR(tmp) = th; - } return state; } -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/