kosaki	2012-12-15 03:08:40 +0900 (Sat, 15 Dec 2012)

  New Revision: 38382

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=38382

  Log:
    * file.c (rb_file_flock): use rb_thread_wait_for() instead of
      rb_thread_polling(). When getting EAGAIN, we need to wait a
      while even if no multi threading.
    * thread.c (sleep_for_polling, rb_thread_polling) removed.

  Modified files:
    trunk/ChangeLog
    trunk/file.c
    trunk/thread.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 38381)
+++ ChangeLog	(revision 38382)
@@ -1,3 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sat Dec 15 03:06:40 2012  KOSAKI Motohiro  <kosaki.motohiro@g...>
+
+	* file.c (rb_file_flock): use rb_thread_wait_for() instead of
+	  rb_thread_polling(). When getting EAGAIN, we need to wait a
+	  while even if no multi threading.
+	* thread.c (sleep_for_polling, rb_thread_polling) removed.
+
 Sat Dec 15 00:03:31 2012  KOSAKI Motohiro  <kosaki.motohiro@g...>
 
 	* signal.c (rb_f_kill): remove rb_thread_polling() because this
Index: thread.c
===================================================================
--- thread.c	(revision 38381)
+++ thread.c	(revision 38382)
@@ -994,15 +994,6 @@ sleep_wait_for_interrupt(rb_thread_t *th https://github.com/ruby/ruby/blob/trunk/thread.c#L994
     sleep_timeval(th, double2timeval(sleepsec),spurious_check);
 }
 
-static void
-sleep_for_polling(rb_thread_t *th)
-{
-    struct timeval time;
-    time.tv_sec = 0;
-    time.tv_usec = 100 * 1000;	/* 0.1 sec */
-    sleep_timeval(th, time, 1);
-}
-
 void
 rb_thread_wait_for(struct timeval time)
 {
@@ -1010,16 +1001,6 @@ rb_thread_wait_for(struct timeval time) https://github.com/ruby/ruby/blob/trunk/thread.c#L1001
     sleep_timeval(th, time, 1);
 }
 
-void
-rb_thread_polling(void)
-{
-    if (!rb_thread_alone()) {
-	rb_thread_t *th = GET_THREAD();
-	RUBY_VM_CHECK_INTS_BLOCKING(th);
-	sleep_for_polling(th);
-    }
-}
-
 /*
  * CAUTION: This function causes thread switching.
  *          rb_thread_check_ints() check ruby's interrupts.
Index: file.c
===================================================================
--- file.c	(revision 38381)
+++ file.c	(revision 38382)
@@ -4200,6 +4200,7 @@ rb_file_flock(VALUE obj, VALUE operation https://github.com/ruby/ruby/blob/trunk/file.c#L4200
 {
     rb_io_t *fptr;
     int op[2], op1;
+    struct timeval time;
 
     rb_secure(2);
     op[1] = op1 = NUM2INT(operation);
@@ -4217,7 +4218,10 @@ rb_file_flock(VALUE obj, VALUE operation https://github.com/ruby/ruby/blob/trunk/file.c#L4218
 	  case EWOULDBLOCK:
 #endif
 	    if (op1 & LOCK_NB) return Qfalse;
-	    rb_thread_polling();
+
+	    time.tv_sec = 0;
+	    time.tv_usec = 100 * 1000;	/* 0.1 sec */
+	    rb_thread_wait_for(time);
 	    rb_io_check_closed(fptr);
 	    continue;
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/