mrkn	2012-12-03 00:09:49 +0900 (Mon, 03 Dec 2012)

  New Revision: 38147

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=38147

  Log:
    * ext/bigdecimal/bigdecimal.c (BigDecimal_new): stop checking string
      taintness.  [Bug #5508] [ruby-core:40510]

  Modified files:
    trunk/ChangeLog
    trunk/ext/bigdecimal/bigdecimal.c
    trunk/test/bigdecimal/test_bigdecimal.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 38146)
+++ ChangeLog	(revision 38147)
@@ -1,6 +1,11 @@
+Sun Dec  3 00:06:00 2012  Kenta Murata  <mrkn@m...>
+
+	* ext/bigdecimal/bigdecimal.c (BigDecimal_new): stop checking string
+	  taintness.  [Bug #5508] [ruby-core:40510]
+
 Sun Dec  2 19:26:47 2012  Masaya Tarui  <tarui@r...>
 
-        * thread.c (RB_GC_SAVE_MACHINE_CONTEXT, rb_gc_save_machine_context): 
+	* thread.c (RB_GC_SAVE_MACHINE_CONTEXT, rb_gc_save_machine_context): 
 	  extract rb_gc_save_machine_context to RB_GC_SAVE_MACHINE_CONTEXT.
 	  NOTE: machine_regs and machine_stack_end must be set in current scope.
 
Index: ext/bigdecimal/bigdecimal.c
===================================================================
--- ext/bigdecimal/bigdecimal.c	(revision 38146)
+++ ext/bigdecimal/bigdecimal.c	(revision 38147)
@@ -2403,7 +2403,6 @@
 	break;
     }
     StringValueCStr(iniValue);
-    rb_check_safe_obj(iniValue);
     return VpAlloc(mf, RSTRING_PTR(iniValue));
 }
 
Index: test/bigdecimal/test_bigdecimal.rb
===================================================================
--- test/bigdecimal/test_bigdecimal.rb	(revision 38146)
+++ test/bigdecimal/test_bigdecimal.rb	(revision 38147)
@@ -100,6 +100,13 @@
     end
   end
 
+  def test_global_new_with_tainted_string
+    Thread.new {
+      $SAFE = 1
+      BigDecimal('1'.taint)
+    }.join
+  end
+
   def test_new
     assert_equal(1, BigDecimal.new("1"))
     assert_equal(1, BigDecimal.new("1", 1))
@@ -150,6 +157,13 @@
     end
   end
 
+  def test_new_with_tainted_string
+    Thread.new {
+      $SAFE = 1
+      BigDecimal.new('1'.taint)
+    }.join
+  end
+
   def _test_mode(type)
     BigDecimal.mode(type, true)
     assert_raise(FloatDomainError) { yield }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/