nari	2012-10-05 18:19:49 +0900 (Fri, 05 Oct 2012)

  New Revision: 37096

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=37096

  Log:
    revert r37091

  Modified files:
    trunk/ChangeLog
    trunk/gc.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 37095)
+++ ChangeLog	(revision 37096)
@@ -21,15 +21,6 @@
 
 	* gc.h: export rb_objspace_reachable_objects_from().
 
-Fri Oct  5 16:04:33 2012  Narihiro Nakamura  <authornari@g...>
-
-	* gc.c (chain_finalized_object): remove to check a mark flag since
-	  all objects are certainly unmarked with rest_sweep.
-
-	* gc.c (rb_objspace_call_finalizer): remove to mark finalizable
-	  objects. The sweeping doesn't push T_ZOMBIE objects to the
-	  freelist.
-
 Thu Oct  4 23:40:04 2012  Narihiro Nakamura  <authornari@g...>
 
 	* gc.c (init_heap): call init_mark_stack before to allocate
Index: gc.c
===================================================================
--- gc.c	(revision 37095)
+++ gc.c	(revision 37096)
@@ -1457,7 +1457,8 @@
 chain_finalized_object(st_data_t key, st_data_t val, st_data_t arg)
 {
     RVALUE *p = (RVALUE *)key, **final_list = (RVALUE **)arg;
-    if ((p->as.basic.flags & FL_FINALIZE) == FL_FINALIZE) {
+    if ((p->as.basic.flags & FL_FINALIZE) == FL_FINALIZE &&
+        !MARKED_IN_BITMAP(GET_HEAP_BITMAP(p), p)) {
 	if (BUILTIN_TYPE(p) != T_ZOMBIE) {
 	    p->as.free.flags = T_ZOMBIE;
 	    RDATA(p)->dfree = 0;
@@ -1499,17 +1500,20 @@
     RVALUE *final_list = 0;
     size_t i;
 
+    /* run finalizers */
     rest_sweep(objspace);
 
     if (ATOMIC_EXCHANGE(finalizing, 1)) return;
 
-    /* run finalizers */
     do {
+	/* XXX: this loop will make no sense */
+	/* because mark will not be removed */
 	finalize_deferred(objspace);
+	mark_tbl(objspace, finalizer_table);
+	gc_mark_stacked_objects(objspace);
 	st_foreach(finalizer_table, chain_finalized_object,
 		   (st_data_t)&deferred_final_list);
     } while (deferred_final_list);
-
     /* force to run finalizer */
     while (finalizer_table->num_entries) {
 	struct force_finalize_list *list = 0;

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/