ruby-changes:24812
From: nobu <ko1@a...>
Date: Fri, 31 Aug 2012 14:27:59 +0900 (JST)
Subject: [ruby-changes:24812] nobu:r36863 (trunk): mkmf.rb: fix race conditions at install-ext
nobu 2012-08-31 14:27:44 +0900 (Fri, 31 Aug 2012) New Revision: 36863 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=36863 Log: mkmf.rb: fix race conditions at install-ext * lib/mkmf.rb (create_makefile): fix race conditions at install-ext. target files need to depend on destination directory timestamp files, not phony trgets. Modified files: trunk/ChangeLog trunk/lib/mkmf.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 36862) +++ ChangeLog (revision 36863) @@ -1,3 +1,9 @@ +Fri Aug 31 14:27:39 2012 Nobuyoshi Nakada <nobu@r...> + + * lib/mkmf.rb (create_makefile): fix race conditions at install-ext. + target files need to depend on destination directory timestamp + files, not phony trgets. + Fri Aug 31 14:03:45 2012 Nobuyoshi Nakada <nobu@r...> * vm_trace.c (clean_hooks): do not access freed memory. Index: lib/mkmf.rb =================================================================== --- lib/mkmf.rb (revision 36862) +++ lib/mkmf.rb (revision 36863) @@ -2152,8 +2152,8 @@ end for f in files dest = "#{dir}/#{File.basename(f)}" - mfile.print("install-rb#{sfx}: #{dest} #{timestamp_file(dir)}\n") - mfile.print("#{dest}: #{f}\n") + mfile.print("install-rb#{sfx}: #{dest}\n") + mfile.print("#{dest}: #{f} #{timestamp_file(dir)}\n") mfile.print("\t$(Q) $(#{$extout ? 'COPY' : 'INSTALL_DATA'}) #{f} $(@D#{sep})\n") if defined?($installed_list) and !$extout mfile.print("\t@echo #{dest}>>$(INSTALLED_LIST)\n") -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/