[前][次][番号順一覧][スレッド一覧]

ruby-changes:24435

From: sorah <ko1@a...>
Date: Sat, 21 Jul 2012 15:14:35 +0900 (JST)
Subject: [ruby-changes:24435] sorah:r36486 (trunk): * lib/test/unit/testcase.rb(method_added): refactoring.

sorah	2012-07-21 15:14:24 +0900 (Sat, 21 Jul 2012)

  New Revision: 36486

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=36486

  Log:
    * lib/test/unit/testcase.rb(method_added): refactoring.

  Modified files:
    trunk/ChangeLog
    trunk/lib/test/unit/testcase.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 36485)
+++ ChangeLog	(revision 36486)
@@ -1,6 +1,10 @@
+Sat Jul 21 15:13:42 2012  Shota Fukumori  <sorah@t...>
+
+	* lib/test/unit/testcase.rb(method_added): refactoring.
+
 Sat Jul 21 14:06:41 2012  Shota Fukumori  <sorah@t...>
 
-	* lib/test/unit.rb: warn when test_* method is redefined.
+	* lib/test/unit/testcase.rb: warn when test_* method is redefined.
 	  Patch by mame (Yusuke Endoh). [Feature #2643] [ruby-core:27790]
 
 	* test/testunit/test_redefinition.rb: Test for above.
Index: lib/test/unit/testcase.rb
===================================================================
--- lib/test/unit/testcase.rb	(revision 36485)
+++ lib/test/unit/testcase.rb	(revision 36486)
@@ -21,15 +21,13 @@
         :sorted
       end
 
-      Methods = {}
-
       def self.method_added(name)
-       return unless name.to_s[/\Atest_/]
-       Methods[self] ||= {}
-       if Methods[self][name]
-         warn("test/unit warning: method #{ self }##{ name } is redefined")
-       end
-       Methods[self][name] = true
+        return unless name.to_s.start_with?("test_")
+        @test_methods ||= {}
+        if @test_methods[name]
+          warn "test/unit warning: method #{ self }##{ name } is redefined"
+        end
+        @test_methods[name] = true
       end
     end
   end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]