[前][次][番号順一覧][スレッド一覧]

ruby-changes:23687

From: knu <ko1@a...>
Date: Mon, 21 May 2012 16:21:46 +0900 (JST)
Subject: [ruby-changes:23687] knu:r35738 (trunk): * ext/syslog/syslog.c (mSyslog_inspect): Use rb_sprintf().

knu	2012-05-21 16:18:47 +0900 (Mon, 21 May 2012)

  New Revision: 35738

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35738

  Log:
    * ext/syslog/syslog.c (mSyslog_inspect): Use rb_sprintf().

  Modified files:
    trunk/ChangeLog
    trunk/ext/syslog/syslog.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 35737)
+++ ChangeLog	(revision 35738)
@@ -1,5 +1,7 @@
-Mon May 21 15:02:37 2012  Akinori MUSHA  <knu@i...>
+Mon May 21 15:10:28 2012  Akinori MUSHA  <knu@i...>
 
+	* ext/syslog/syslog.c (mSyslog_inspect): Use rb_sprintf().
+
 	* ext/syslog/syslog.c (mSyslog_inspect): Make sure self is a
 	  module before calling rb_class2name().
 
Index: ext/syslog/syslog.c
===================================================================
--- ext/syslog/syslog.c	(revision 35737)
+++ ext/syslog/syslog.c	(revision 35738)
@@ -313,24 +313,17 @@
  */
 static VALUE mSyslog_inspect(VALUE self)
 {
-    char buf[1024];
-
     Check_Type(self, T_MODULE);
 
-    if (syslog_opened) {
-	snprintf(buf, sizeof(buf),
-	  "<#%s: opened=true, ident=\"%s\", options=%d, facility=%d, mask=%d>",
-	  rb_class2name(self),
-	  syslog_ident,
-	  syslog_options,
-	  syslog_facility,
-	  syslog_mask);
-    } else {
-	snprintf(buf, sizeof(buf),
-	  "<#%s: opened=false>", rb_class2name(self));
-    }
+    if (!syslog_opened)
+	return rb_sprintf("<#%s: opened=false>", rb_class2name(self));
 
-    return rb_str_new2(buf);
+    return rb_sprintf("<#%s: opened=true, ident=\"%s\", options=%d, facility=%d, mask=%d>",
+		      rb_class2name(self),
+		      syslog_ident,
+		      syslog_options,
+		      syslog_facility,
+		      syslog_mask);
 }
 
 /* Returns self, for backward compatibility.

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]