[前][次][番号順一覧][スレッド一覧]

ruby-changes:23586

From: nagachika <ko1@a...>
Date: Sun, 13 May 2012 23:51:05 +0900 (JST)
Subject: [ruby-changes:23586] nagachika:r35637 (trunk): * test/ruby/test_io.rb (test_flush_in_finalizer1): don't use IO.for_fd

nagachika	2012-05-13 23:50:49 +0900 (Sun, 13 May 2012)

  New Revision: 35637

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35637

  Log:
    * test/ruby/test_io.rb (test_flush_in_finalizer1): don't use IO.for_fd
      to close IO objects. it create IO object with already closed fd, and
      cause occasional Errno::EBADF in following tests. [ruby-core:45020]
      [Bug #6228]

  Modified files:
    trunk/ChangeLog
    trunk/test/ruby/test_io.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 35636)
+++ ChangeLog	(revision 35637)
@@ -1,5 +1,12 @@
-Sun May 13 23:32:16 2012  CHIKANAGA Tomoyuki  <nagachika00@g...>
+Sun May 13 23:38:31 2012  CHIKANAGA Tomoyuki  <nagachika@r...>
 
+	* test/ruby/test_io.rb (test_flush_in_finalizer1): don't use IO.for_fd
+	  to close IO objects. it create IO object with already closed fd, and
+	  cause occasional Errno::EBADF in following tests. [ruby-core:45020]
+	  [Bug #6228]
+
+Sun May 13 23:32:16 2012  CHIKANAGA Tomoyuki  <nagachika@r...>
+
 	* test/ruby/test_io.rb (TestIO): revert r35631. it broke the intent of
 	  test_flush_in_finalizer1.  [ruby-core:43951] [Bug ##6228]
 
Index: test/ruby/test_io.rb
===================================================================
--- test/ruby/test_io.rb	(revision 35636)
+++ test/ruby/test_io.rb	(revision 35637)
@@ -1891,7 +1891,7 @@
       }
     end
   ensure
-    fds.each {|fd| IO.for_fd(fd).close rescue next}
+    GC.start
   end
 
   def test_flush_in_finalizer2

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]