[前][次][番号順一覧][スレッド一覧]

ruby-changes:23404

From: nobu <ko1@a...>
Date: Tue, 24 Apr 2012 15:51:55 +0900 (JST)
Subject: [ruby-changes:23404] nobu:r35455 (trunk): * lib/optparse.rb (OptionParser#to_a): should split by end-of-line

nobu	2012-04-24 15:51:44 +0900 (Tue, 24 Apr 2012)

  New Revision: 35455

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35455

  Log:
    * lib/optparse.rb (OptionParser#to_a): should split by end-of-line
      [ruby-dev:45568][Bug #6348]

  Modified files:
    trunk/ChangeLog
    trunk/lib/optparse.rb
    trunk/test/optparse/test_summary.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 35454)
+++ ChangeLog	(revision 35455)
@@ -1,5 +1,8 @@
-Tue Apr 24 14:54:03 2012  Nobuyoshi Nakada  <nobu@r...>
+Tue Apr 24 15:51:41 2012  Nobuyoshi Nakada  <nobu@r...>
 
+	* lib/optparse.rb (OptionParser#to_a): should split by end-of-line
+	  [ruby-dev:45568][Bug #6348]
+
 	* lib/optparse.rb (OptionParser#to_a): String#to_a is no longer
 	  defined.  [ruby-dev:45568][Bug #6348]
 
Index: lib/optparse.rb
===================================================================
--- lib/optparse.rb	(revision 35454)
+++ lib/optparse.rb	(revision 35455)
@@ -1071,7 +1071,7 @@
   #
   # Returns option summary list.
   #
-  def to_a; summarize([*banner]) end
+  def to_a; summarize("#{banner}".split(/$/)) end
 
   #
   # Checks if an argument is given twice, in which case an ArgumentError is
Index: test/optparse/test_summary.rb
===================================================================
--- test/optparse/test_summary.rb	(revision 35454)
+++ test/optparse/test_summary.rb	(revision 35455)
@@ -31,8 +31,8 @@
   end
 
   def test_summary
-    o = OptionParser.new("foo bar")
-    assert_equal("foo bar\n", o.to_s)
-    assert_equal(["foo bar"], o.to_a)
+    o = OptionParser.new("foo\nbar")
+    assert_equal("foo\nbar\n", o.to_s)
+    assert_equal(["foo", "bar"], o.to_a)
   end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]