nobu	2012-04-11 22:01:16 +0900 (Wed, 11 Apr 2012)

  New Revision: 35299

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35299

  Log:
    * sprintf.c (rb_str_format): fix exception message encoding.

  Modified files:
    trunk/sprintf.c
    trunk/test/ruby/test_sprintf.rb

Index: sprintf.c
===================================================================
--- sprintf.c	(revision 35298)
+++ sprintf.c	(revision 35299)
@@ -119,11 +119,11 @@
 #define GETNTHARG(nth) \
     (((nth) >= argc) ? (rb_raise(rb_eArgError, "too few arguments"), 0) : argv[(nth)])
 
-#define GETNAMEARG(id, name, len) ( \
+#define GETNAMEARG(id, name, len, enc) ( \
     posarg > 0 ? \
-    (rb_raise(rb_eArgError, "named%.*s after unnumbered(%d)", (len), (name), posarg), 0) : \
+    (rb_enc_raise((enc), rb_eArgError, "named%.*s after unnumbered(%d)", (len), (name), posarg), 0) : \
     posarg == -1 ? \
-    (rb_raise(rb_eArgError, "named%.*s after numbered", (len), (name)), 0) :	\
+    (rb_enc_raise((enc), rb_eArgError, "named%.*s after numbered", (len), (name)), 0) :	\
     (posarg = -2, rb_hash_lookup2(get_hash(&hash, argc, argv), (id), Qundef)))
 
 #define GETNUM(n, val) \
@@ -578,19 +578,20 @@
 		if ((size_t)(p - start) >= INT_MAX) {
 		    const int message_limit = 20;
 		    len = (int)(rb_enc_right_char_head(start, start + message_limit, p, enc) - start);
-		    rb_raise(rb_eArgError, "too long name (%"PRIdSIZE" bytes) - %.*s...%c",
-			     (size_t)(p - start - 2), len, start, term);
+		    rb_enc_raise(enc, rb_eArgError,
+				 "too long name (%"PRIdSIZE" bytes) - %.*s...%c",
+				 (size_t)(p - start - 2), len, start, term);
 		}
 #endif
 		len = (int)(p - start + 1); /* including parenthesis */
 		if (id) {
-		    rb_raise(rb_eArgError, "named%.*s after <%s>",
-			     len, start, rb_id2name(id));
+		    rb_enc_raise(enc, rb_eArgError, "named%.*s after <%s>",
+				 len, start, rb_id2name(id));
 		}
 		id = rb_intern3(start + 1, len - 2 /* without parenthesis */, enc);
-		nextvalue = GETNAMEARG(ID2SYM(id), start, len);
+		nextvalue = GETNAMEARG(ID2SYM(id), start, len, enc);
 		if (nextvalue == Qundef) {
-		    rb_raise(rb_eKeyError, "key%.*s not found", len, start);
+		    rb_enc_raise(enc, rb_eKeyError, "key%.*s not found", len, start);
 		}
 		if (term == '}') goto format_s;
 		p++;
Index: test/ruby/test_sprintf.rb
===================================================================
--- test/ruby/test_sprintf.rb	(revision 35298)
+++ test/ruby/test_sprintf.rb	(revision 35299)
@@ -333,6 +333,25 @@
     assert_equal("named<key2> after <key>", e.message)
   end
 
+  def test_named_untyped_enc
+    key = "\u{3012}"
+    [Encoding::UTF_8, Encoding::EUC_JP].each do |enc|
+      k = key.encode(enc)
+      e = assert_raise(ArgumentError) {sprintf("%1$<#{k}>s", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named<#{k}> after numbered", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%s%s%<#{k}>s", "foo", "bar", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named<#{k}> after unnumbered(2)", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%<key><#{k}>s", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named<#{k}> after <key>", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%<#{k}><key>s", k.to_sym => "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named<key> after <#{k}>", e.message)
+    end
+  end
+
   def test_named_typed
     assert_equal("value", sprintf("%{key}", :key => "value"))
     e = assert_raise(ArgumentError) {sprintf("%1${key2}", :key => "value")}
@@ -343,4 +362,23 @@
     assert_equal("named{key2} after <key>", e.message)
     assert_equal("value{key2}", sprintf("%{key}{key2}", :key => "value"))
   end
+
+  def test_named_typed_enc
+    key = "\u{3012}"
+    [Encoding::UTF_8, Encoding::EUC_JP].each do |enc|
+      k = key.encode(enc)
+      e = assert_raise(ArgumentError) {sprintf("%1${#{k}}s", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named{#{k}} after numbered", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%s%s%{#{k}}s", "foo", "bar", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named{#{k}} after unnumbered(2)", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%<key>{#{k}}s", key: "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named{#{k}} after <key>", e.message)
+      e = assert_raise(ArgumentError) {sprintf("%<#{k}>{key}s", k.to_sym => "value")}
+      assert_equal(enc, e.message.encoding)
+      assert_equal("named{key} after <#{k}>", e.message)
+    end
+  end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/