ruby-changes:23068
From: nobu <ko1@a...>
Date: Fri, 23 Mar 2012 12:04:30 +0900 (JST)
Subject: [ruby-changes:23068] nobu:r35118 (trunk): * file.c (rb_file_s_basename): rb_enc_asciicompat() evaluates the argument multiple times.
nobu 2012-03-23 12:04:20 +0900 (Fri, 23 Mar 2012) New Revision: 35118 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35118 Log: * file.c (rb_file_s_basename): rb_enc_asciicompat() evaluates the argument multiple times. Modified files: trunk/file.c Index: file.c =================================================================== --- file.c (revision 35117) +++ file.c (revision 35118) @@ -3640,9 +3640,9 @@ rb_encoding *enc; if (rb_scan_args(argc, argv, "11", &fname, &fext) == 2) { - rb_encoding *enc; StringValue(fext); - if (!rb_enc_asciicompat(enc = rb_enc_get(fext))) { + enc = rb_enc_get(fext); + if (!rb_enc_asciicompat(enc)) { rb_raise(rb_eEncCompatError, "ascii incompatible character encodings: %s", rb_enc_name(enc)); } -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/