ruby-changes:22584
From: nobu <ko1@a...>
Date: Thu, 16 Feb 2012 05:42:01 +0900 (JST)
Subject: [ruby-changes:22584] nobu:r34633 (trunk): * insns.def (splatarray): make new array if flag is set.
nobu 2012-02-16 05:41:38 +0900 (Thu, 16 Feb 2012) New Revision: 34633 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=34633 Log: * insns.def (splatarray): make new array if flag is set. * compile.c (iseq_compile_each): make new array with splat. [ruby-core:21901][Feature #1125] Modified files: trunk/ChangeLog trunk/compile.c trunk/insns.def trunk/test/ruby/test_basicinstructions.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 34632) +++ ChangeLog (revision 34633) @@ -1,3 +1,10 @@ +Thu Feb 16 05:41:35 2012 Nobuyoshi Nakada <nobu@r...> + + * insns.def (splatarray): make new array if flag is set. + + * compile.c (iseq_compile_each): make new array with + splat. [ruby-core:21901][Feature #1125] + Thu Feb 16 00:14:04 2012 Kazuhiro NISHIYAMA <zn@m...> * lib/abbrev.rb (Array#abbrev): add missing '"' in documentation. Index: insns.def =================================================================== --- insns.def (revision 34632) +++ insns.def (revision 34633) @@ -533,6 +533,9 @@ if (NIL_P(tmp)) { tmp = rb_ary_new3(1, ary); } + else if (RTEST(flag)) { + tmp = rb_ary_dup(tmp); + } obj = tmp; } Index: compile.c =================================================================== --- compile.c (revision 34632) +++ compile.c (revision 34633) @@ -4643,7 +4643,7 @@ } case NODE_SPLAT:{ COMPILE(ret, "splat", node->nd_head); - ADD_INSN1(ret, nd_line(node), splatarray, Qfalse); + ADD_INSN1(ret, nd_line(node), splatarray, Qtrue); if (poped) { ADD_INSN(ret, nd_line(node), pop); Index: test/ruby/test_basicinstructions.rb =================================================================== --- test/ruby/test_basicinstructions.rb (revision 34632) +++ test/ruby/test_basicinstructions.rb (revision 34633) @@ -632,7 +632,7 @@ assert_equal 'i', $~[9] assert_equal 'x', $` assert_equal 'abcdefghi', $& - assert_equal 'y', $' + assert_equal "y", $' assert_equal 'i', $+ assert_equal 'a', $1 assert_equal 'b', $2 @@ -662,15 +662,20 @@ end def test_array_splat + feature1125 = '[ruby-core:21901]' + a = [] assert_equal [], [*a] assert_equal [1], [1, *a] + assert_not_same(a, [*a], feature1125) a = [2] assert_equal [2], [*a] assert_equal [1, 2], [1, *a] + assert_not_same(a, [*a], feature1125) a = [2, 3] assert_equal [2, 3], [*a] assert_equal [1, 2, 3], [1, *a] + assert_not_same(a, [*a], feature1125) a = nil assert_equal [], [*a] -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/