ruby-changes:21836
From: usa <ko1@a...>
Date: Mon, 28 Nov 2011 22:28:38 +0900 (JST)
Subject: [ruby-changes:21836] usa:r33885 (trunk): * test/rake/test_rake_directory_task.rb
usa 2011-11-28 22:28:26 +0900 (Mon, 28 Nov 2011) New Revision: 33885 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=33885 Log: * test/rake/test_rake_directory_task.rb (TestRakeDirectoryTask#test_directory_win32): shouldn't create any file/directory on root directory. create on @tempdir (= Dir.pwd). see https://github.com/jimweirich/rake/issues/91 Modified files: trunk/ChangeLog trunk/test/rake/test_rake_directory_task.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 33884) +++ ChangeLog (revision 33885) @@ -1,3 +1,10 @@ +Mon Nov 28 22:26:31 2011 NAKAMURA Usaku <usa@r...> + + * test/rake/test_rake_directory_task.rb + (TestRakeDirectoryTask#test_directory_win32): shouldn't create any + file/directory on root directory. create on @tempdir (= Dir.pwd). + see https://github.com/jimweirich/rake/issues/91 + Mon Nov 28 12:57:29 2011 Nobuyoshi Nakada <nobu@r...> * io.c (rb_write_error2): fwrite() returns ssize_t. Index: test/rake/test_rake_directory_task.rb =================================================================== --- test/rake/test_rake_directory_task.rb (revision 33884) +++ test/rake/test_rake_directory_task.rb (revision 33885) @@ -27,20 +27,26 @@ if Rake::Win32.windows? def test_directory_win32 + drive = Dir.pwd + while drive != File.dirname(drive) + drive = File.dirname(drive) + end + drive = drive[0...-1] if drive[-1] == ?/ + desc "WIN32 DESC" - directory 'c:/a/b/c' - assert_equal FileTask, Task['c:'].class - assert_equal FileCreationTask, Task['c:/a'].class - assert_equal FileCreationTask, Task['c:/a/b'].class - assert_equal FileCreationTask, Task['c:/a/b/c'].class - assert_nil Task['c:/'].comment - assert_equal "WIN32 DESC", Task['c:/a/b/c'].comment - assert_nil Task['c:/a/b'].comment + directory File.join(Dir.pwd, 'a/b/c') + assert_equal FileTask, Task[drive].class if drive[-1] == ?: + assert_equal FileCreationTask, Task[File.join(Dir.pwd, 'a')].class + assert_equal FileCreationTask, Task[File.join(Dir.pwd, 'a/b')].class + assert_equal FileCreationTask, Task[File.join(Dir.pwd, 'a/b/c')].class + assert_nil Task[drive].comment + assert_equal "WIN32 DESC", Task[File.join(Dir.pwd, 'a/b/c')].comment + assert_nil Task[File.join(Dir.pwd, 'a/b')].comment verbose(false) { - Task['c:/a/b'].invoke + Task[File.join(Dir.pwd, 'a/b')].invoke } - assert File.exist?('c:/a/b') - refute File.exist?('c:/a/b/c') + assert File.exist?(File.join(Dir.pwd, 'a/b')) + refute File.exist?(File.join(Dir.pwd, 'a/b/c')) end end end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/