[前][次][番号順一覧][スレッド一覧]

ruby-changes:2150

From: ko1@a...
Date: 6 Oct 2007 14:34:42 +0900
Subject: [ruby-changes:2150] nobu - Ruby:r13641 (trunk): * insns.def (opt_eq): get rid of gcc bug.

nobu	2007-10-06 14:32:37 +0900 (Sat, 06 Oct 2007)

  New Revision: 13641

  Modified files:
    trunk/ChangeLog
    trunk/include/ruby/intern.h
    trunk/insns.def
    trunk/re.c
    trunk/string.c

  Log:
    * insns.def (opt_eq): get rid of gcc bug.


  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/string.c?r1=13641&r2=13640
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/ChangeLog?r1=13641&r2=13640
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/re.c?r1=13641&r2=13640
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/insns.def?r1=13641&r2=13640
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/include/ruby/intern.h?r1=13641&r2=13640

Index: include/ruby/intern.h
===================================================================
--- include/ruby/intern.h	(revision 13640)
+++ include/ruby/intern.h	(revision 13641)
@@ -442,7 +442,7 @@
 unsigned long genrand_int32(void);
 double genrand_real(void);
 /* re.c */
-int rb_memcmp(const void*,const void*,long);
+#define rb_memcmp memcmp
 int rb_memcicmp(const void*,const void*,long);
 long rb_memsearch(const void*,long,const void*,long);
 VALUE rb_reg_nth_defined(int, VALUE);
Index: re.c
===================================================================
--- re.c	(revision 13640)
+++ re.c	(revision 13641)
@@ -91,6 +91,8 @@
     return 0;
 }
 
+#undef rb_memcmp
+
 int
 rb_memcmp(const void *p1, const void *p2, long len)
 {
Index: insns.def
===================================================================
--- insns.def	(revision 13640)
+++ insns.def	(revision 13641)
@@ -1697,18 +1697,18 @@
 
 	    VALUE str1 = recv;
 	    VALUE str2 = obj;
-	    if (str1 == str2) {
-		val = Qtrue;
-	    }
-	    else if (!ENCODING_GET(str1) && !ENCODING_GET(str2) &&
-		     RSTRING_LEN(str1) == RSTRING_LEN(str2) &&
-		     rb_memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2),
-			       RSTRING_LEN(str1)) == 0) {
-		val = Qtrue;
-	    }
-	    else {
+	    val = Qtrue;
+	    do {
+		if (str1 == str2) break;
+		if (!ENCODING_GET(str1) && !ENCODING_GET(str2)) {
+		    if (RSTRING_LEN(str1) == RSTRING_LEN(str2)) {
+			int cmp = memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2),
+					 RSTRING_LEN(str1));
+			if (!cmp) break;
+		    }
+		}
 		val = rb_str_equal(str1, str2);
-	    }
+	    } while (0);
 	}
 	else {
 	    goto INSN_LABEL(normal_dispatch);
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 13640)
+++ ChangeLog	(revision 13641)
@@ -1,3 +1,7 @@
+Sat Oct  6 14:32:30 2007  U-nobu-PC\nobu  <nobu@r...>
+
+	* insns.def (opt_eq): get rid of gcc bug.
+
 Sat Oct  6 02:34:18 2007  Yukihiro Matsumoto  <matz@r...>
 
 	* include/ruby/defines.h: no longer provide DEFAULT_KCODE. 
Index: string.c
===================================================================
--- string.c	(revision 13640)
+++ string.c	(revision 13641)
@@ -1226,7 +1226,7 @@
 
     rb_enc_check(str1, str2);	/* xxxx error-less encoding check? */
     len = lesser(RSTRING_LEN(str1), RSTRING_LEN(str2));
-    retval = rb_memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2), len);
+    retval = memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2), len);
     if (retval == 0) {
 	if (RSTRING_LEN(str1) == RSTRING_LEN(str2)) return 0;
 	if (RSTRING_LEN(str1) > RSTRING_LEN(str2)) return 1;
@@ -1485,7 +1485,7 @@
     t = RSTRING_PTR(sub);
     for (;;) {
 	s = str_nth(sbeg, e, pos, enc);
-	if (rb_memcmp(s, t, slen) == 0) {
+	if (memcmp(s, t, slen) == 0) {
 	    return pos;
 	}
 	if (pos == 0) break;
@@ -4090,7 +4090,7 @@
 	    p -= n;
 	}
 	if (c == newline &&
-	    (rslen <= 1 || rb_memcmp(RSTRING_PTR(rs), p, rslen) == 0)) {
+	    (rslen <= 1 || memcmp(RSTRING_PTR(rs), p, rslen) == 0)) {
 	    line = rb_str_new5(str, s, p - s + (rslen ? rslen : n));
 	    OBJ_INFECT(line, str);
 	    rb_yield(line);
@@ -4325,7 +4325,7 @@
 
     if (p[len-1] == newline &&
 	(rslen <= 1 ||
-	 rb_memcmp(RSTRING_PTR(rs), p+len-rslen, rslen) == 0)) {
+	 memcmp(RSTRING_PTR(rs), p+len-rslen, rslen) == 0)) {
 	rb_str_modify(str);
 	STR_SET_LEN(str, RSTRING_LEN(str) - rslen);
 	RSTRING_PTR(str)[RSTRING_LEN(str)] = '\0';
@@ -5064,7 +5064,7 @@
 	if (NIL_P(tmp)) continue;
 	rb_enc_check(str, tmp);
 	if (RSTRING_LEN(str) < RSTRING_LEN(tmp)) continue;
-	if (rb_memcmp(RSTRING_PTR(str), RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
+	if (memcmp(RSTRING_PTR(str), RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
 	    return Qtrue;
     }
     return Qfalse;
@@ -5087,8 +5087,8 @@
 	if (NIL_P(tmp)) continue;
 	rb_enc_check(str, tmp);
 	if (RSTRING_LEN(str) < RSTRING_LEN(tmp)) continue;
-	if (rb_memcmp(RSTRING_PTR(str) + RSTRING_LEN(str) - RSTRING_LEN(tmp),
-		      RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
+	if (memcmp(RSTRING_PTR(str) + RSTRING_LEN(str) - RSTRING_LEN(tmp),
+		   RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
 	    return Qtrue;
     }
     return Qfalse;

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml

[前][次][番号順一覧][スレッド一覧]