ruby-changes:21413
From: kosaki <ko1@a...>
Date: Thu, 13 Oct 2011 18:19:21 +0900 (JST)
Subject: [ruby-changes:21413] kosaki:r33462 (trunk): * atomic.h(ATOMIC_SET): add cast to void to prevent misuse.
kosaki 2011-10-13 18:19:10 +0900 (Thu, 13 Oct 2011) New Revision: 33462 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=33462 Log: * atomic.h(ATOMIC_SET): add cast to void to prevent misuse. [ruby-dev:44596] [Bug #5439] Modified files: trunk/ChangeLog trunk/atomic.h Index: ChangeLog =================================================================== --- ChangeLog (revision 33461) +++ ChangeLog (revision 33462) @@ -1,3 +1,8 @@ +Thu Oct 13 18:13:04 2011 KOSAKI Motohiro <kosaki.motohiro@g...> + + * atomic.h(ATOMIC_SET): add cast to void to prevent misuse. + [ruby-dev:44596] [Bug #5439] + Thu Oct 13 18:04:27 2011 Nobuyoshi Nakada <nobu@r...> * gc.c (rb_gc_finalize_deferred, rb_objspace_call_finalizer): Index: atomic.h =================================================================== --- atomic.h (revision 33461) +++ atomic.h (revision 33462) @@ -36,7 +36,7 @@ * http://gcc.gnu.org/onlinedocs/gcc/Atomic-Builtins.html */ typedef unsigned int rb_atomic_t; /* Anything OK */ -# define ATOMIC_SET(var, val) __sync_lock_test_and_set(&(var), (val)) +# define ATOMIC_SET(var, val) (void)__sync_lock_test_and_set(&(var), (val)) # define ATOMIC_INC(var) __sync_fetch_and_add(&(var), 1) # define ATOMIC_DEC(var) __sync_fetch_and_sub(&(var), 1) # define ATOMIC_OR(var, val) __sync_or_and_fetch(&(var), (val)) @@ -46,7 +46,7 @@ typedef int rb_atomic_t; extern rb_atomic_t ruby_atomic_exchange(rb_atomic_t *ptr, rb_atomic_t val); -# define ATOMIC_SET(var, val) ((var) = (val)) +# define ATOMIC_SET(var, val) (void)((var) = (val)) # define ATOMIC_INC(var) (++(var)) # define ATOMIC_DEC(var) (--(var)) # define ATOMIC_OR(var, val) ((var) |= (val)) -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/