[前][次][番号順一覧][スレッド一覧]

ruby-changes:21350

From: naruse <ko1@a...>
Date: Tue, 4 Oct 2011 18:44:18 +0900 (JST)
Subject: [ruby-changes:21350] naruse:r33399 (trunk): Revert r33397 because it cause segv.

naruse	2011-10-04 18:44:08 +0900 (Tue, 04 Oct 2011)

  New Revision: 33399

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=33399

  Log:
    Revert r33397 because it cause segv.
    
    "* class.c (class_alloc): allocate extra memory after containing"

  Modified files:
    trunk/ChangeLog
    trunk/class.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 33398)
+++ ChangeLog	(revision 33399)
@@ -3,11 +3,6 @@
 	* lib/time.rb (Time.strptime): use Time.at if d[:seconds] is set.
 	  Reported by Christopher Eberz. [ruby-core:39903] Bug #5399
 
-Tue Oct  4 15:04:43 2011  Nobuyoshi Nakada  <nobu@r...>
-
-	* class.c (class_alloc): allocate extra memory after containing
-	  object setup to get rid of rare-but-potential memory leak.
-
 Tue Oct  4 11:44:10 2011  NARUSE, Yui  <naruse@r...>
 
 	* gc.c (rb_gc_set_params): ruby_verbose can be Qnil, so use RTEST.
Index: class.c
===================================================================
--- class.c	(revision 33398)
+++ class.c	(revision 33399)
@@ -49,9 +49,10 @@
 static VALUE
 class_alloc(VALUE flags, VALUE klass)
 {
+    rb_classext_t *ext = ALLOC(rb_classext_t);
     NEWOBJ(obj, struct RClass);
     OBJSETUP(obj, klass, flags);
-    obj->ptr = ALLOC(rb_classext_t);
+    obj->ptr = ext;
     RCLASS_IV_TBL(obj) = 0;
     RCLASS_CONST_TBL(obj) = 0;
     RCLASS_M_TBL(obj) = 0;

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]