matz	2007-10-04 18:54:53 +0900 (Thu, 04 Oct 2007)

  New Revision: 13623

  Modified files:
    trunk/ChangeLog
    trunk/include/ruby/intern.h
    trunk/re.c
    trunk/string.c

  Log:
    revert rb_memcmp() change to pacify GCC optimizer

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/string.c?r1=13623&r2=13622
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/ChangeLog?r1=13623&r2=13622
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/re.c?r1=13623&r2=13622
  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/include/ruby/intern.h?r1=13623&r2=13622

Index: include/ruby/intern.h
===================================================================
--- include/ruby/intern.h	(revision 13622)
+++ include/ruby/intern.h	(revision 13623)
@@ -442,7 +442,7 @@
 unsigned long genrand_int32(void);
 double genrand_real(void);
 /* re.c */
-#define rb_memcmp(a,b,c) memcmp(a,b,c)
+int rb_memcmp(const void*,const void*,long);
 int rb_memcicmp(const void*,const void*,long);
 long rb_memsearch(const void*,long,const void*,long);
 VALUE rb_reg_nth_defined(int, VALUE);
Index: re.c
===================================================================
--- re.c	(revision 13622)
+++ re.c	(revision 13623)
@@ -91,6 +91,12 @@
     return 0;
 }
 
+int
+rb_memcmp(const void *p1, const void *p2, long len)
+{
+    return rb_memcicmp(p1, p2, len);
+}
+
 long
 rb_memsearch(const void *x0, long m, const void *y0, long n)
 {
@@ -897,11 +903,6 @@
 	RBASIC(re)->flags |= reg_kcode;
     }
 
-     if (state) { 	 
-	 FL_UNSET(re, REG_CASESTATE); 	 
-	 RREGEXP(re)->ptr->options &= ~ONIG_OPTION_IGNORECASE; 	 
-	 need_recompile = 1; 	 
-     }
     if (need_recompile) {
 	onig_errmsg_buffer err;
 	int r;
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 13622)
+++ ChangeLog	(revision 13623)
@@ -1,9 +1,3 @@
-Thu Oct  4 18:23:28 2007  Yukihiro Matsumoto  <matz@r...>
-
-	* re.c (rb_memcmp): no longer useful without ruby_ignorecase.
-
-	* re.c (rb_reg_prepare_re): revert recompile condition.
-
 Thu Oct  4 17:33:18 2007  Yukihiro Matsumoto  <matz@r...>
 
 	* re.c (kcode_setter): Perl-ish global variable `$=' no longer
Index: string.c
===================================================================
--- string.c	(revision 13622)
+++ string.c	(revision 13623)
@@ -1226,7 +1226,7 @@
 
     rb_enc_check(str1, str2);	/* xxxx error-less encoding check? */
     len = lesser(RSTRING_LEN(str1), RSTRING_LEN(str2));
-    retval = memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2), len);
+    retval = rb_memcmp(RSTRING_PTR(str1), RSTRING_PTR(str2), len);
     if (retval == 0) {
 	if (RSTRING_LEN(str1) == RSTRING_LEN(str2)) return 0;
 	if (RSTRING_LEN(str1) > RSTRING_LEN(str2)) return 1;
@@ -1485,7 +1485,7 @@
     t = RSTRING_PTR(sub);
     for (;;) {
 	s = str_nth(sbeg, e, pos, enc);
-	if (memcmp(s, t, slen) == 0) {
+	if (rb_memcmp(s, t, slen) == 0) {
 	    return pos;
 	}
 	if (pos == 0) break;
@@ -4090,7 +4090,7 @@
 	    p -= n;
 	}
 	if (c == newline &&
-	    (rslen <= 1 || memcmp(RSTRING_PTR(rs), p, rslen) == 0)) {
+	    (rslen <= 1 || rb_memcmp(RSTRING_PTR(rs), p, rslen) == 0)) {
 	    line = rb_str_new5(str, s, p - s + (rslen ? rslen : n));
 	    OBJ_INFECT(line, str);
 	    rb_yield(line);
@@ -4325,7 +4325,7 @@
 
     if (p[len-1] == newline &&
 	(rslen <= 1 ||
-	 memcmp(RSTRING_PTR(rs), p+len-rslen, rslen) == 0)) {
+	 rb_memcmp(RSTRING_PTR(rs), p+len-rslen, rslen) == 0)) {
 	rb_str_modify(str);
 	STR_SET_LEN(str, RSTRING_LEN(str) - rslen);
 	RSTRING_PTR(str)[RSTRING_LEN(str)] = '\0';
@@ -5064,7 +5064,7 @@
 	if (NIL_P(tmp)) continue;
 	rb_enc_check(str, tmp);
 	if (RSTRING_LEN(str) < RSTRING_LEN(tmp)) continue;
-	if (memcmp(RSTRING_PTR(str), RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
+	if (rb_memcmp(RSTRING_PTR(str), RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
 	    return Qtrue;
     }
     return Qfalse;
@@ -5087,7 +5087,7 @@
 	if (NIL_P(tmp)) continue;
 	rb_enc_check(str, tmp);
 	if (RSTRING_LEN(str) < RSTRING_LEN(tmp)) continue;
-	if (memcmp(RSTRING_PTR(str) + RSTRING_LEN(str) - RSTRING_LEN(tmp),
+	if (rb_memcmp(RSTRING_PTR(str) + RSTRING_LEN(str) - RSTRING_LEN(tmp),
 		      RSTRING_PTR(tmp), RSTRING_LEN(tmp)) == 0)
 	    return Qtrue;
     }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml