ruby-changes:21079
From: usa <ko1@a...>
Date: Wed, 31 Aug 2011 00:04:21 +0900 (JST)
Subject: [ruby-changes:21079] usa:r33128 (trunk): * win32/win32.c, include/ruby/intern.h (rb_w32_fd_copy): implement
usa 2011-08-31 00:04:11 +0900 (Wed, 31 Aug 2011) New Revision: 33128 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=33128 Log: * win32/win32.c, include/ruby/intern.h (rb_w32_fd_copy): implement for rb_thread_select() in thread.c. the use of rb_fd_copy() is introduced in r33117. [Bug #5229] [ruby-core:39102] * thread.c (rb_thread_select): must call rb_fd_init() before using rb_fdset_t. see the implementations of rb_fd_init()s if you want to know the reason. Modified files: trunk/ChangeLog trunk/include/ruby/intern.h trunk/thread.c trunk/win32/win32.c Index: include/ruby/intern.h =================================================================== --- include/ruby/intern.h (revision 33127) +++ include/ruby/intern.h (revision 33128) @@ -286,6 +286,8 @@ void rb_fd_set(int, rb_fdset_t *); #define rb_fd_clr(n, f) rb_w32_fdclr((n), (f)->fdset) #define rb_fd_isset(n, f) rb_w32_fdisset((n), (f)->fdset) +#define rb_fd_copy(d, s, n) rb_w32_fd_copy((d), (s), (n)) +void rb_w32_fd_copy(rb_fdset_t *, const fd_set *, int); #define rb_fd_dup(d, s) rb_w32_fd_dup((d), (s)) void rb_w32_fd_dup(rb_fdset_t *dst, const rb_fdset_t *src); #define rb_fd_select(n, rfds, wfds, efds, timeout) rb_w32_select((n), (rfds) ? ((rb_fdset_t*)(rfds))->fdset : NULL, (wfds) ? ((rb_fdset_t*)(wfds))->fdset : NULL, (efds) ? ((rb_fdset_t*)(efds))->fdset: NULL, (timeout)) Index: ChangeLog =================================================================== --- ChangeLog (revision 33127) +++ ChangeLog (revision 33128) @@ -1,3 +1,14 @@ +Tue Aug 30 23:59:36 2011 NAKAMURA Usaku <usa@r...> + + * win32/win32.c, include/ruby/intern.h (rb_w32_fd_copy): implement + for rb_thread_select() in thread.c. the use of rb_fd_copy() is + introduced in r33117. + [Bug #5229] [ruby-core:39102] + + * thread.c (rb_thread_select): must call rb_fd_init() before using + rb_fdset_t. see the implementations of rb_fd_init()s if you want to + know the reason. + Tue Aug 30 22:34:45 2011 CHIKANAGA Tomoyuki <nagachika00@g...> * test/dl/test_callback.rb (test_callback_with_string): prevents Index: thread.c =================================================================== --- thread.c (revision 33127) +++ thread.c (revision 33128) @@ -2686,7 +2686,7 @@ rb_thread_select(int max, fd_set * read, fd_set * write, fd_set * except, struct timeval *timeout) { - rb_fdset_t fdsets[3] = { 0 }; + rb_fdset_t fdsets[3]; rb_fdset_t *rfds = NULL; rb_fdset_t *wfds = NULL; rb_fdset_t *efds = NULL; @@ -2694,14 +2694,17 @@ if (read) { rfds = &fdsets[0]; + rb_fd_init(rfds); rb_fd_copy(rfds, read, max); } if (write) { wfds = &fdsets[1]; + rb_fd_init(wfds); rb_fd_copy(wfds, write, max); } if (except) { efds = &fdsets[2]; + rb_fd_init(wfds); rb_fd_copy(efds, except, max); } Index: win32/win32.c =================================================================== --- win32/win32.c (revision 33127) +++ win32/win32.c (revision 33128) @@ -2468,6 +2468,21 @@ /* License: Ruby's */ void +rb_w32_fd_copy(rb_fdset_t *dst, const fd_set *src, int max) +{ + max = min(src->fd_count, max); + if ((UINT)dst->capa < max) { + dst->capa = (src->fd_count / FD_SETSIZE + 1) * FD_SETSIZE; + dst->fdset = xrealloc(dst->fdset, sizeof(unsigned int) + sizeof(SOCKET) * dst->capa); + } + + memcpy(dst->fdset->fd_array, src->fd_array, + max * sizeof(src->fd_array[0])); + dst->fdset->fd_count = src->fd_count; +} + +/* License: Ruby's */ +void rb_w32_fd_dup(rb_fdset_t *dst, const rb_fdset_t *src) { if ((UINT)dst->capa < src->fdset->fd_count) { @@ -2477,6 +2492,7 @@ memcpy(dst->fdset->fd_array, src->fdset->fd_array, src->fdset->fd_count * sizeof(src->fdset->fd_array[0])); + dst->fdset->fd_count = src->fdset->fd_count; } // -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/