[前][次][番号順一覧][スレッド一覧]

ruby-changes:20899

From: drbrain <ko1@a...>
Date: Sat, 13 Aug 2011 01:56:59 +0900 (JST)
Subject: [ruby-changes:20899] drbrain:r32948 (trunk): * lib/rake: Update to Rake 0.9.2.2. Prevent pollution of toplevel

drbrain	2011-08-13 01:56:48 +0900 (Sat, 13 Aug 2011)

  New Revision: 32948

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=32948

  Log:
    * lib/rake:  Update to Rake 0.9.2.2.  Prevent pollution of toplevel
      namespace by Commands.  Remove unused variable and debugging
      statement in tests.

  Modified files:
    trunk/ChangeLog
    trunk/lib/rake/application.rb
    trunk/lib/rake/dsl_definition.rb
    trunk/lib/rake/version.rb
    trunk/test/rake/helper.rb
    trunk/test/rake/test_rake_dsl.rb
    trunk/test/rake/test_rake_functional.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 32947)
+++ ChangeLog	(revision 32948)
@@ -1,3 +1,9 @@
+Sat Aug 13 01:56:11 2011  Eric Hodel  <drbrain@s...>
+
+	* lib/rake:  Update to Rake 0.9.2.2.  Prevent pollution of toplevel
+	  namespace by Commands.  Remove unused variable and debugging
+	  statement in tests.
+
 Fri Aug 12 11:39:35 2011  KOSAKI Motohiro  <kosaki.motohiro@g...>
 
 	* configure.in: Desbribe "no" configure option for site_ruby
Index: lib/rake/dsl_definition.rb
===================================================================
--- lib/rake/dsl_definition.rb	(revision 32947)
+++ lib/rake/dsl_definition.rb	(revision 32948)
@@ -144,10 +144,12 @@
         Rake.application.add_import(fn)
       end
     end
+
   end
 
+  DeprecatedCommands = Object.new.extend(DSL)
+
   module DeprecatedObjectDSL # :nodoc:
-    Commands = Object.new.extend DSL
     DSL.private_instance_methods(false).each do |name|
       line = __LINE__+1
       class_eval %{
@@ -160,8 +162,8 @@
             end
             $stderr.puts "WARNING: DSL method \#{self.class}##{name} called at \#{caller.first}"
           end
-          Rake::DeprecatedObjectDSL::Commands.send(:#{name}, *args, &block)
-          end
+          Rake::DeprecatedCommands.send(:#{name}, *args, &block)
+        end
         private :#{name}
       }, __FILE__, line
     end
Index: lib/rake/application.rb
===================================================================
--- lib/rake/application.rb	(revision 32947)
+++ lib/rake/application.rb	(revision 32948)
@@ -348,6 +348,7 @@
         ],
         ['--rakelibdir', '--rakelib', '-R RAKELIBDIR',
           "Auto-import any .rake files in RAKELIBDIR. (default is 'rakelib')",
+          # HACK Use File::PATH_SEPARATOR
           lambda { |value| options.rakelib = value.split(':') }
         ],
         ['--require', '-r MODULE', "Require MODULE before executing rakefile.",
Index: lib/rake/version.rb
===================================================================
--- lib/rake/version.rb	(revision 32947)
+++ lib/rake/version.rb	(revision 32948)
@@ -1,5 +1,5 @@
 module Rake
-  VERSION = '0.9.2.1'
+  VERSION = '0.9.2.2'
 
   module Version # :nodoc: all
     MAJOR, MINOR, BUILD = VERSION.split '.'
Index: test/rake/test_rake_functional.rb
===================================================================
--- test/rake/test_rake_functional.rb	(revision 32947)
+++ test/rake/test_rake_functional.rb	(revision 32948)
@@ -436,7 +436,7 @@
   def run_ruby(option_list)
     puts "COMMAND: [#{RUBY} #{option_list.join ' '}]" if @verbose
 
-    inn, out, err, wait = Open3.popen3(Gem.ruby, *option_list)
+    inn, out, err = Open3.popen3(Gem.ruby, *option_list)
     inn.close
 
     @out = out.read
Index: test/rake/helper.rb
===================================================================
--- test/rake/helper.rb	(revision 32947)
+++ test/rake/helper.rb	(revision 32948)
@@ -282,7 +282,6 @@
 task :prep => :clean do
   mkdir_p 'src'
   N.times do |n|
-    puts "DBG: Touching src/foo#{n}"
     touch "src/foo#{n}"
   end
 end
Index: test/rake/test_rake_dsl.rb
===================================================================
--- test/rake/test_rake_dsl.rb	(revision 32947)
+++ test/rake/test_rake_dsl.rb	(revision 32948)
@@ -56,6 +56,10 @@
     assert_match(/test_rake_dsl\.rb:\d+/, err)
   end
 
+  def test_no_commands_constant
+    assert ! defined?(Commands), "should not define Commands"
+  end
+
   def test_deprecated_object_dsl_with_suppressed_warnings
     Rake.application.options.ignore_deprecate = true
     out, err = capture_io do

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]